Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2696083002: Reapply "Switch to the new analysis driver in analyzer_cli." (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
kevmoo, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Switch to the new analysis driver in analyzer_cli." R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/623d2868a961f143485b256a04c13f6c1fe05a08

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 5 chunks +26 lines, -16 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 4 chunks +12 lines, -2 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
scheglov
3 years, 10 months ago (2017-02-14 22:21:49 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-14 22:27:35 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 623d2868a961f143485b256a04c13f6c1fe05a08 (presubmit successful).
3 years, 10 months ago (2017-02-14 22:41:49 UTC) #4
rmacnak
On 2017/02/14 22:41:49, scheglov wrote: > Committed patchset #1 (id:1) manually as > 623d2868a961f143485b256a04c13f6c1fe05a08 (presubmit ...
3 years, 10 months ago (2017-02-14 23:49:03 UTC) #5
kevmoo
DBQ https://codereview.chromium.org/2696083002/diff/1/sdk/bin/dartanalyzer File sdk/bin/dartanalyzer (right): https://codereview.chromium.org/2696083002/diff/1/sdk/bin/dartanalyzer#newcode48 sdk/bin/dartanalyzer:48: DEV_OPTIONS="--use-analysis-driver-memory-byte-store" This feels weird – why isn't this ...
3 years, 10 months ago (2017-02-15 00:03:11 UTC) #7
scheglov
3 years, 10 months ago (2017-02-15 00:11:59 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2696083002/diff/1/sdk/bin/dartanalyzer
File sdk/bin/dartanalyzer (right):

https://codereview.chromium.org/2696083002/diff/1/sdk/bin/dartanalyzer#newcode48
sdk/bin/dartanalyzer:48: DEV_OPTIONS="--use-analysis-driver-memory-byte-store"
On 2017/02/15 00:03:11, kevmoo wrote:
> This feels weird – why isn't this just the default?

This script is used to run shared tests in cases when we make changes to
analyzer.
We don't want to forget to update AnalysisDriver.DATA_VERSION and get all green
from cached results.

Powered by Google App Engine
This is Rietveld 408576698