Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2696073003: Check for no constructors before iterating (issue 28703) (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check for no constructors before iterating (issue 28703) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e86f70e27d4b140bec00e8163c876d22abda91f9

Patch Set 1 #

Patch Set 2 : address comments #

Patch Set 3 : revert to original #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 2 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-14 21:07:29 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-02-14 21:18:47 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-02-14 21:26:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e86f70e27d4b140bec00e8163c876d22abda91f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698