Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: ash/public/cpp/shelf_types.h

Issue 2696073002: Merge ShelfItemDelegate::ItemSelected & LauncherItemDelegate::Activate. (Closed)
Patch Set: Cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/cpp/shelf_types.h
diff --git a/ash/public/cpp/shelf_types.h b/ash/public/cpp/shelf_types.h
index d63dfc8fb759a2a809df76cb959500d0d624f7d1..b8b7c30f29be65921c177b467ee2102d98b902ed 100644
--- a/ash/public/cpp/shelf_types.h
+++ b/ash/public/cpp/shelf_types.h
@@ -55,6 +55,28 @@ enum ShelfBackgroundType {
SHELF_BACKGROUND_MAXIMIZED,
};
+// Source of the launch or activation request, for tracking.
+enum ShelfLaunchSource {
+ LAUNCH_FROM_UNKNOWN,
James Cook 2017/02/15 00:44:40 Can you document each of these while you're here?
msw 2017/02/15 19:59:18 Done.
+ LAUNCH_FROM_APP_LIST,
+ LAUNCH_FROM_APP_LIST_SEARCH,
+};
+
+// The actions that may be performed when a shelf item is selected.
+// TODO(msw): Update kConstantValueNaming to ENUM_VALUE_NAMING.
+enum ShelfAction {
+ // No action was taken.
+ kNoAction,
+ // A new window was created.
+ kNewWindowCreated,
+ // An existing inactive window was activated.
+ kExistingWindowActivated,
+ // The currently active window was minimized.
+ kExistingWindowMinimized,
+ // The app list launcher menu was shown.
+ kAppListMenuShown,
+};
+
typedef int ShelfID;
const int kInvalidShelfID = 0;

Powered by Google App Engine
This is Rietveld 408576698