[Ash MD] Remove some non-MD code from HoverHighlightView

[Ash MD] Remove some non-MD code from HoverHighlightView

A first pass at removing the unused non-MD code
from HoverHighlightView. Follow-on cleanup items
are tracked in TODOs.

BUG=686345
TEST=manual, no functional changes

[tdanderson, 2017-02-14 22:42:40]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-02-14 22:43:06]

tdanderson@chromium.org changed reviewers:
+ mohsen@chromium.org

[tdanderson, 2017-02-14 22:43:07]

Mohsen, can you please take a look?

[commit-bot: I haz the power, 2017-02-14 22:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2017-02-14 22:48:20]

tdanderson@chromium.org changed reviewers:
+ varkha@chromium.org

[tdanderson, 2017-02-14 22:48:20]

https://codereview.chromium.org/2696033003/diff/1/ash/common/system/tray/hove...
File ash/common/system/tray/hover_highlight_view.cc (left):

https://codereview.chromium.org/2696033003/diff/1/ash/common/system/tray/hove...
ash/common/system/tray/hover_highlight_view.cc:343: if (hover_ == hover)
Mohsen and +varkha@, on second thought I think we may actually want to keep
tracking the state of |hover_| even in MD (though we don't want to change any
colors as in lines 349, 351). If you look at the call sites of the hover()
accessor, it looks as though this at one time served the purpose of preventing a
detailed view list from moving the element underneath the cursor outside the
visible region while the list was still being populated. We may have broken this
with the MD work. Mind taking a second look and letting me know what you think?

[commit-bot: I haz the power, 2017-02-15 00:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:30:54]

Dry run: This issue passed the CQ dry run.