Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2696013004: Make the test's dart:core import dart:async in tests. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the test's dart:core import dart:async in tests. SDK's version does it, and we probably don't want to protect aginst something what happens only in tests, but is not expected actually. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7e9f4ba34c7aa4de65312b943b8f0ff6a4aec37a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/analyzer_cli/test/data/package_with_embedder_yaml/lib/core.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-14 21:13:54 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-14 21:27:32 UTC) #2
scheglov
3 years, 10 months ago (2017-02-14 21:31:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e9f4ba34c7aa4de65312b943b8f0ff6a4aec37a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698