Issue 26960002: Don't crash by form submission in a document with null encoding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26960002: Don't crash by form submission in a document with null encoding. (Closed)

Created:
7 years, 2 months ago by tkent

Modified:
7 years, 2 months ago

Reviewers:
keishi, Kunihiko Sakamoto

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Don't crash by form submission in a document with null encoding. The CString object which is passed to normalizeLineEndingsToCRLF() can be a null string. It is created in FormDataList::appendString(), and it produces a null CString if FormDataList::m_encoding is a null encoding. BUG=291744, 306086 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159428

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -1 line)			Patch
A	LayoutTests/fast/forms/form-submit-in-image-document.html	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/form-submit-in-image-document-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/text/LineEnding.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/26960002/1

7 years, 2 months ago (2013-10-11 02:05:15 UTC) #3

Message was sent while issue was closed.

Change committed as 159428

Expand Messages | Collapse Messages