WIP: redirect some LayoutBox methods to ng fragments

third_party/WebKit/Source/core/layout/LayoutBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef LayoutBox_h
 #define LayoutBox_h
 
 #include "core/CoreExport.h"
+#include "core/layout/ng/ng_physical_box_fragment.h"
 #include "core/layout/LayoutBoxModelObject.h"
 #include "core/layout/OverflowModel.h"
 #include "platform/scroll/ScrollTypes.h"
 #include "wtf/Compiler.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
 class LayoutBlockFlow;
@@ skipping 160 matching lines @@
 
   bool backgroundIsKnownToBeOpaqueInRect(
       const LayoutRect& localRect) const override;
 
   virtual bool backgroundShouldAlwaysBeClipped() const { return false; }
 
   // Use this with caution! No type checking is done!
   LayoutBox* firstChildBox() const;
   LayoutBox* firstInFlowChildBox() const;
   LayoutBox* lastChildBox() const;
-
+ private:
+  RefPtr<NGPhysicalBoxFragment> m_ngPhysicalBoxFragment;
+ public:
+  void setNGPhysicalFragment(RefPtr<NGPhysicalBoxFragment> fragment) {
+    m_ngPhysicalBoxFragment = fragment;
+  }
   int pixelSnappedWidth() const { return m_frameRect.pixelSnappedWidth(); }
   int pixelSnappedHeight() const { return m_frameRect.pixelSnappedHeight(); }
 
   void setX(LayoutUnit x) {
     if (x == m_frameRect.x())
       return;
     m_frameRect.setX(x);
+//    m_ngPhysicalBoxFragment->setX(x);

[ikilpatrick, 2017/02/16 18:24:20]

yeah so this is what i had in mind, I'd delete m_frameRect and just replace all
the locations that touch it to m_ngPhysicalBoxFragment....

[dgrogan, 2017/02/16 18:54:09]

What should I do about layout calling location() (and I'm sure others) before
LayoutBox has a m_ngPhysicalBoxFragment? Start with a placeholder and then have
NGFragmentBuilder replace it?

     locationChanged();
   }
   void setY(LayoutUnit y) {
     if (y == m_frameRect.y())
       return;
     m_frameRect.setY(y);
     locationChanged();
   }
   void setWidth(LayoutUnit width) {
     if (width == m_frameRect.width())
@@ skipping 81 matching lines @@
     else
       setHeight(size);
   }
   void setLogicalHeight(LayoutUnit size) {
     if (style()->isHorizontalWritingMode())
       setHeight(size);
     else
       setWidth(size);
   }
 
-  LayoutPoint location() const { return m_frameRect.location(); }
+  LayoutPoint location() const {
+    if (m_ngPhysicalBoxFragment) {

[dgrogan, 2017/02/16 03:16:00]

location() is called during layout before NGFragmentBuilder::ToBoxFragment sets 
LayoutBox::m_ngPhysicalBoxFragment, necessitating this check.

+      DCHECK(m_frameRect.location() == m_ngPhysicalBoxFragment->Location());
+    }
+    return m_frameRect.location();
+  }
+
   LayoutSize locationOffset() const {
     return LayoutSize(m_frameRect.x(), m_frameRect.y());
   }
-  LayoutSize size() const { return m_frameRect.size(); }
+  LayoutSize size() const {
+    if (m_ngPhysicalBoxFragment) {
+      DCHECK(m_frameRect.size() == m_ngPhysicalBoxFragment->LegacySize());
+    }
+    return m_frameRect.size();
+  }
   IntSize pixelSnappedSize() const { return m_frameRect.pixelSnappedSize(); }
 
   void setLocation(const LayoutPoint& location) {
     if (location == m_frameRect.location())
       return;
     m_frameRect.setLocation(location);
     locationChanged();
   }
 
   // The ancestor box that this object's location and physicalLocation are
@@ skipping 1303 matching lines @@
          breakValue == EBreakBetween::kLeft ||
          breakValue == EBreakBetween::kPage ||
          breakValue == EBreakBetween::kRecto ||
          breakValue == EBreakBetween::kRight ||
          breakValue == EBreakBetween::kVerso;
 }
 
 }  // namespace blink
 
 #endif  // LayoutBox_h