Use logdog butler subcommand to run tests.

tools/mb/mb.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """MB - the Meta-Build wrapper around GYP and GN
 
 MB is a wrapper script for GYP and GN that can be used to generate build files
 for sets of canned configurations and analyze them.
 """
 
 from __future__ import print_function
 
 import argparse
 import ast
 import errno
 import json
+import logging

[dnj, 2017/02/22 21:46:45]

It doesn't look like you're using this.

[BigBossZhiling, 2017/02/22 23:49:52]

Done.

 import os
 import pipes
 import pprint
 import re
 import shutil
 import sys
 import subprocess
 import tempfile
 import traceback
 import urllib2
@@ skipping 1051 matching lines @@
     executable_suffix = '.exe' if self.platform == 'win32' else ''
 
     cmdline = []
     extra_files = []
 
     if test_type == 'nontest':
       self.WriteFailureAndRaise('We should not be isolating %s.' % target,
                                 output_path=None)
 
     if android and test_type != "script":
-      logdog_command = [
-          '--logdog-bin-cmd', './../../bin/logdog_butler',
-          '--project', 'chromium',
-          '--service-account-json',
-          '/creds/service_accounts/service-account-luci-logdog-publisher.json',
-          '--prefix', 'android/swarming/logcats/${SWARMING_TASK_ID}',
-          '--source', '${ISOLATED_OUTDIR}/logcats',
-          '--name', 'unified_logcats',
-      ]
       test_cmdline = [
           self.PathJoin('bin', 'run_%s' % target),
           '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',
           '--target-devices-file', '${SWARMING_BOT_FILE}',
-          '-v'
-      ]
-      cmdline = (['./../../build/android/test_wrapper/logdog_wrapper.py']
-                 + logdog_command + test_cmdline)
+          '-v', '--upload-full-logcat', '${ISOLATED_OUTDIR}/logcats']
+      project = 'chromium'
+      output = 'logdog,host=services-dot-luci-logdog.appspot.com'

[dnj, 2017/02/22 21:46:45]

Note that this notation is changing to:
-coordinator-host luci-logdog.appspot.com
-output logdog,service="services"

This will only impact new Butler versions, but will need to be changed when you
use a new Butler version. If you can, I'd just commit to it now to save yourself
the trouble.

[BigBossZhiling, 2017/02/22 23:49:52]

Done. It is "services" instead of just services?

+      prefix = 'android/swarming/logcats/${SWARMING_TASK_ID}'
+
+      # Call test_cmdline through logdog butler subcommand.
+      cmdline = [
+          '../../bin/logdog_butler', '-project', project,
+          '-output', output,
+          '-prefix', prefix,
+          'run', '--'] + test_cmdline

[dnj, 2017/02/22 21:46:45]

Same comment from last time. You're not connecting STDOUT or STDERR to LogDog,
and you're not creating a stream server for subprocesses to connect to, so this
is basically not doing anything at all.

Your goal is to have it so that "test_cmdline" can use the LogDog Python library
to send logs, right? If so, you need to set a "-streamserver-uri" here.

[BigBossZhiling, 2017/02/22 23:49:52]

Done.

     elif use_xvfb and test_type == 'windowed_test_launcher':
       extra_files = [
           '../../testing/test_env.py',
           '../../testing/xvfb.py',
       ]
       cmdline = [
         '../../testing/xvfb.py',
         './' + str(executable) + executable_suffix,
         '--brave-new-test-launcher',
         '--test-launcher-bot-mode',
@@ skipping 453 matching lines @@
   # Then check to see if the arg contains any metacharacters other than
   # double quotes; if it does, quote everything (including the double
   # quotes) for safety.
   if any(a in UNSAFE_FOR_CMD for a in arg):
     arg = ''.join('^' + a if a in ALL_META_CHARS else a for a in arg)
   return arg
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))