native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc - Issue 269593011: [NaCl SDK] Modifying size_t and int to off_t.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

Issue 269593011: [NaCl SDK] Modifying size_t and int to off_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc b/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

index f5f8089389ace71b5794f676fe290c3f311031d3..ee5e5f33681905de086e65866a0a056a711ec03a 100644

--- a/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

+++ b/native_client_sdk/src/libraries/nacl_io/httpfs/http_fs.cc

@@ -390,7 +390,7 @@ Error HttpFs::LoadManifest(const std::string& manifest_name,

if (error)

return error;

- size_t size;

+ off_t size;

error = manifest_node->GetSize(&size);

if (error)

return error;