[NaCl SDK] Modifying size_t and int to off_t.

[NaCl SDK] Modifying size_t and int to off_t.

This modifies a few locations that utilize size_t and int to track the
number of bytes to instead use off_t.

BUG=369279
R=binji@chromium.org, sbc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268022

[Matthew Turk, 2014-05-02 17:28:32]

I've tested this patch locally in pepper_canary as of this morning, but I can't
get the current native_client_sdk/src/build_tools/build_sdk.py to run to
completion at present (libgcrypt-config is missing for arm?)

Additionally, there is a point where a format string is hardcoded; I was unable
to determine the correct format string macro to use at that point.

[Sam Clegg, 2014-05-02 17:33:23]

On 2014/05/02 17:28:32, Matthew Turk wrote:
> I've tested this patch locally in pepper_canary as of this morning, but I
can't
> get the current native_client_sdk/src/build_tools/build_sdk.py to run to
> completion at present (libgcrypt-config is missing for arm?)
> 
> Additionally, there is a point where a format string is hardcoded; I was
unable
> to determine the correct format string macro to use at that point.

Hey matt, sorry about the build_sdk.py breakage.   There is a non-obvious step
to fix it which is to run "gclient runhooks" with "GYP_DEFINES=target_arch=arm"
in your environment.

[Sam Clegg, 2014-05-02 17:36:06]

lgtm with nits.

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc:246: *out_size
= static_cast<off_t>(info.size);
Is this cast still needed?

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:423:
"bytes=%llu-%llu",
I'm not sure %llu works on windows can you use PRIu64?

[binji, 2014-05-02 17:44:15]

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:86: bool
ParseContentLength(const StringMap_t& headers, size_t* content_length) {
s/size_t/off_t/

[Matthew Turk, 2014-05-02 18:47:43]

This responds to the comments -- thanks for the pointer on runhooks, Sam.  I'm
in the midst of doing a clean build of the application stack that showed this
error in the first place to ensure it works in all the use cases I had it. 
Doing the change binji suggested caused a few other places to need modification
as well, so I've threaded off_t a few other places.

ptal

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc:246: *out_size
= static_cast<off_t>(info.size);
On 2014/05/02 17:36:06, Sam Clegg wrote:
> Is this cast still needed?

Done.

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:86: bool
ParseContentLength(const StringMap_t& headers, size_t* content_length) {
On 2014/05/02 17:44:15, binji wrote:
> s/size_t/off_t/

Done.

https://codereview.chromium.org/269593011/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:423:
"bytes=%llu-%llu",
On 2014/05/02 17:36:06, Sam Clegg wrote:
> I'm not sure %llu works on windows can you use PRIu64?

Done.  Had to include some additional headers to make this work with -Wall.

[binji, 2014-05-02 19:02:35]

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:11: #include
<iostream>
Can you add this to osinttypes.h instead?

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:112: "bytes %"
PRIu64 "-%" PRIu64 "/%" PRIu64,
should be SCNi64, I believe. If you need to, define the correct mappings in
osinttypes.h

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:426: "bytes=%"
PRIu64 "-%" PRIu64,
off_t is signed, so PRIi64

[Matthew Turk, 2014-05-02 19:13:30]

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:11: #include
<iostream>
On 2014/05/02 19:02:35, binji wrote:
> Can you add this to osinttypes.h instead?

Done.

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:112: "bytes %"
PRIu64 "-%" PRIu64 "/%" PRIu64,
On 2014/05/02 19:02:35, binji wrote:
> should be SCNi64, I believe. If you need to, define the correct mappings in
> osinttypes.h

Done.

https://codereview.chromium.org/269593011/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:426: "bytes=%"
PRIu64 "-%" PRIu64,
On 2014/05/02 19:02:35, binji wrote:
> off_t is signed, so PRIi64

Done.

[Sam Clegg, 2014-05-02 19:32:49]

https://codereview.chromium.org/269593011/diff/40001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/40001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:11: #include
<iostream>
Why is this needed?   Doesn't osinttypes.h suffice?

[Matthew Turk, 2014-05-02 19:34:54]

https://codereview.chromium.org/269593011/diff/40001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc (right):

https://codereview.chromium.org/269593011/diff/40001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/httpfs/http_fs_node.cc:11: #include
<iostream>
On 2014/05/02 19:32:49, Sam Clegg wrote:
> Why is this needed?   Doesn't osinttypes.h suffice?

It does -- this was a careless inclusion.

[binji, 2014-05-02 19:44:18]

awesome, lgtm. Please wait for the SDK trybots before using the CQ.

[Matthew Turk, 2014-05-02 20:30:03]

I've updated the tests to match the new GetSize definition.  Could you bump the
trybots?

[Matthew Turk, 2014-05-02 23:02:07]

The CQ bit was checked by matthewturk@gmail.com

[commit-bot: I haz the power, 2014-05-02 23:02:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/matthewturk@gmail.com/269593011/80001

[commit-bot: I haz the power, 2014-05-02 23:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 23:29:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
  linux_chromium_chromeos_rel on tryserver.chromium

[Matthew Turk, 2014-05-02 23:41:58]

This should fix the trybots on ChromeOS that the CQ failed on.

[binji, 2014-05-03 00:00:41]

The CQ bit was checked by binji@chromium.org

[commit-bot: I haz the power, 2014-05-03 00:01:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/matthewturk@gmail.com/269593011/90001

[commit-bot: I haz the power, 2014-05-03 00:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-03 00:49:10]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[Matthew Turk, 2014-05-03 01:11:49]

On 2014/05/03 00:49:10, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_chromium_x64_rel on tryserver.chromium

This time I can't figure out where the issue came from -- can't tell how it's
related.

[Sam Clegg, 2014-05-03 01:26:55]

On 2014/05/03 01:11:49, Matthew Turk wrote:
> On 2014/05/03 00:49:10, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel on tryserver.chromium
> 
> This time I can't figure out where the issue came from -- can't tell how it's
> related.

Most likely unrelated (AKA a flake).

I will retry the CQ.

[Sam Clegg, 2014-05-03 01:26:55]

On 2014/05/03 01:11:49, Matthew Turk wrote:
> On 2014/05/03 00:49:10, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   win_chromium_x64_rel on tryserver.chromium
> 
> This time I can't figure out where the issue came from -- can't tell how it's
> related.

Most likely unrelated (AKA a flake).

I will retry the CQ.

[Sam Clegg, 2014-05-03 01:27:06]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-05-03 01:30:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/matthewturk@gmail.com/269593011/90001

[commit-bot: I haz the power, 2014-05-03 02:58:25]

Change committed as 268022