GPU: Use virtual contexts on NVidia.

GPU: Use virtual contexts on NVidia.

They asked for this since optimizing MakeCurrent will take
significantly longer.

BUG=369316
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268029

[epenner, 2014-05-01 22:27:30]

Ptal.

Daniel, is there any way to toggle virtual contexts via a command-line such that
they can play with this after the fact?

[no sievers, 2014-05-01 22:34:47]

On 2014/05/01 22:27:30, epenner wrote:
> Ptal.
> 
> Daniel, is there any way to toggle virtual contexts via a command-line such
that
> they can play with this after the fact?

LGTM

You can use --disable-gpu-driver-bug-workarounds to disable all of them.

[epenner, 2014-05-01 23:23:26]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-05-01 23:24:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/epenner@chromium.org/269593008/1

[Zhenyao Mo, 2014-05-01 23:31:05]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2014-05-01 23:31:47]

Please always update the list version.

(I unchecked the CQ, please update then check CQ again)

[epenner, 2014-05-01 23:36:48]

On 2014/05/01 23:31:47, Zhenyao Mo wrote:
> Please always update the list version.
> 
> (I unchecked the CQ, please update then check CQ again)


Thanks for the heads up!

[epenner, 2014-05-01 23:36:53]

The CQ bit was checked by epenner@chromium.org

[commit-bot: I haz the power, 2014-05-01 23:37:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/epenner@chromium.org/269593008/20001

[no sievers, 2014-05-01 23:59:35]

The CQ bit was unchecked by sievers@chromium.org

[no sievers, 2014-05-02 00:01:03]

On second thought: Can we check GL_VERSION beginswith OpenGL ES 3.1?

Just so that we don't accidentally trigger something unexpected on older
devices.
I know there is no good reason why it shouldn't work, but you know how it goes
:)

[epenner, 2014-05-02 01:10:09]

On 2014/05/02 00:01:03, sievers wrote:
> On second thought: Can we check GL_VERSION beginswith OpenGL ES 3.1?
> 
> Just so that we don't accidentally trigger something unexpected on older
> devices.
> I know there is no good reason why it shouldn't work, but you know how it goes
> :)

Yeah especially if we want to merge. Ideally though these could be merged for
36. Or maybe we can just remove this second one if it gets better.

Anyway, ptal for two separate workarounds.

[epennerAtGoogle, 2014-05-02 01:19:32]

On 2014/05/02 01:10:09, epenner wrote:
> On 2014/05/02 00:01:03, sievers wrote:
> > On second thought: Can we check GL_VERSION beginswith OpenGL ES 3.1?
> > 
> > Just so that we don't accidentally trigger something unexpected on older
> > devices.
> > I know there is no good reason why it shouldn't work, but you know how it
goes
> > :)
> 
> Yeah especially if we want to merge. Ideally though these could be merged for
> 36. Or maybe we can just remove this second one if it gets better.
> 
> Anyway, ptal for two separate workarounds.

Actually this doesn't work yet. It looks like the GL_VERSION actually starts
with "OpenGL ES 3.1", and for some reason that's still not triggering. I'll look
into it.

[epenner, 2014-05-03 00:20:23]

Okay. We chatted and I've put together this version for merge. I had to move the
Android specific code such that it sets the command-line early enough to detect
it and apply the workaround. But it doesn't look like that should cause any
problems.

Btw, I'll get rid of this entire bit of Android code and move it to where we set
Android compositor flags, in a follow up.

[epenner, 2014-05-03 00:39:33]

Actually, this avoids touching the command-line, by adding the work-around to
the set directly instead. Ptal.

[Zhenyao Mo, 2014-05-03 00:42:23]

LGTM as far as it's tested.

[epennerAtGoogle, 2014-05-03 00:46:42]

On 2014/05/03 00:42:23, Zhenyao Mo wrote:
> LGTM as far as it's tested.

Thanks. I've tested on the device we are interested in to make sure it works.
Also, sorry I've got to run and can't do the proper fix to support this in JSON.

Alternatively, we could just enable virtual contexts for all NV devices for 36,
since we'll have longer to test them.

[epennerAtGoogle, 2014-05-03 00:46:47]

The CQ bit was checked by epenner@google.com

[commit-bot: I haz the power, 2014-05-03 00:47:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/epenner@chromium.org/269593008/100001

[epennerAtGoogle, 2014-05-03 00:53:16]

The CQ bit was unchecked by epenner@google.com

[epennerAtGoogle, 2014-05-03 00:54:17]

The CQ bit was checked by epenner@google.com

[commit-bot: I haz the power, 2014-05-03 00:55:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/epenner@chromium.org/269593008/120001

[commit-bot: I haz the power, 2014-05-03 03:28:51]

Change committed as 268029