Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 269593002: Reland Extend AXTreeSourceViews to support views::Widget and aura::Window. (Closed)

Created:
6 years, 7 months ago by David Tseng
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Visibility:
Public.

Description

Reland Extend AXTreeSourceViews to support views::Widget and aura::Window. original cl https://codereview.chromium.org/246433012/ BUG=309681 TBR=dtseng@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267487

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+971 lines, -451 lines) Patch
A + chrome/browser/ui/ash/accessibility/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/automation_manager_views.h View 1 3 chunks +17 lines, -6 lines 0 comments Download
A + chrome/browser/ui/ash/accessibility/automation_manager_views.cc View 1 4 chunks +24 lines, -15 lines 0 comments Download
A chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/accessibility/ax_root_obj_wrapper.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/accessibility/ax_tree_source_views.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/accessibility/ax_tree_source_views.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/accessibility/ax_tree_source_views_unittest.cc View 1 1 chunk +137 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/accessibility/automation_manager_views.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/ui/views/accessibility/automation_manager_views.cc View 1 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
ui/accessibility/ax_view_state.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
ui/views/accessibility/ax_aura_obj_cache.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_aura_obj_cache.cc View 1 1 chunk +129 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_aura_obj_wrapper.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_tree_source_views.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
ui/views/accessibility/ax_tree_source_views.cc View 1 1 chunk +0 lines, -156 lines 0 comments Download
ui/views/accessibility/ax_tree_source_views_unittest.cc View 1 1 chunk +0 lines, -85 lines 0 comments Download
ui/views/accessibility/ax_view_obj_wrapper.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_view_obj_wrapper.cc View 1 1 chunk +65 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_widget_obj_wrapper.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_window_obj_wrapper.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
ui/views/accessibility/ax_window_obj_wrapper.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
ui/views/views.gyp View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-05-01 01:21:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/269593002/20001
6 years, 7 months ago (2014-05-01 01:22:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 01:22:26 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_ui.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-01 01:22:27 UTC) #4
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-05-01 01:38:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/269593002/40001
6 years, 7 months ago (2014-05-01 01:39:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 01:39:21 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_ui.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-01 01:39:22 UTC) #8
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-05-01 01:45:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/269593002/60001
6 years, 7 months ago (2014-05-01 01:46:01 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 03:02:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-01 03:02:45 UTC) #12
David Tseng
The CQ bit was checked by dtseng@chromium.org
6 years, 7 months ago (2014-05-01 03:09:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/269593002/60001
6 years, 7 months ago (2014-05-01 03:10:53 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 08:38:01 UTC) #15
Message was sent while issue was closed.
Change committed as 267487

Powered by Google App Engine
This is Rietveld 408576698