Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2695923012: Options cleanup for the command-line analyzer. (Closed)

Created:
3 years, 10 months ago by devoncarew
Modified:
3 years, 10 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 1 chunk +17 lines, -20 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 5 chunks +22 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
Options cleanup for the command-line analyzer: - hide the --machine option (it's deprecated) - remove ...
3 years, 10 months ago (2017-02-17 01:32:43 UTC) #2
scheglov
lgtm
3 years, 10 months ago (2017-02-17 04:30:26 UTC) #3
pquitslund
lgtm
3 years, 10 months ago (2017-02-17 13:44:05 UTC) #4
devoncarew
3 years, 10 months ago (2017-02-17 14:19:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4be2c9b1f40320107fd9829a66b8f14923baeac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698