Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: headless/public/util/generic_url_request_job.cc

Issue 2695923010: Add Network.setSendRequestIdHeader and use it in headless (Closed)
Patch Set: Add the header unconditionally Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "headless/public/util/generic_url_request_job.h" 5 #include "headless/public/util/generic_url_request_job.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 #include <algorithm> 8 #include <algorithm>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "headless/public/util/url_request_dispatcher.h" 11 #include "headless/public/util/url_request_dispatcher.h"
12 #include "net/base/io_buffer.h" 12 #include "net/base/io_buffer.h"
13 #include "net/base/net_errors.h" 13 #include "net/base/net_errors.h"
14 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 14 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
15 #include "net/cookies/cookie_store.h" 15 #include "net/cookies/cookie_store.h"
16 #include "net/http/http_response_headers.h" 16 #include "net/http/http_response_headers.h"
17 #include "net/url_request/url_request_context.h" 17 #include "net/url_request/url_request_context.h"
18 18
19 namespace headless { 19 namespace headless {
20 namespace { 20 namespace {
21 21
22 // True if the request method is "safe" (per section 4.2.1 of RFC 7231). 22 // True if the request method is "safe" (per section 4.2.1 of RFC 7231).
23 bool IsMethodSafe(const std::string& method) { 23 bool IsMethodSafe(const std::string& method) {
24 return method == "GET" || method == "HEAD" || method == "OPTIONS" || 24 return method == "GET" || method == "HEAD" || method == "OPTIONS" ||
25 method == "TRACE"; 25 method == "TRACE";
26 } 26 }
27 27
28 // Keep in sync with X_DevTools_Emulate_Network_Conditions_Client_Id defined in
Sami 2017/02/27 12:39:07 Comment talks about a different header.
alex clarke (OOO till 29th) 2017/02/27 13:51:16 Done.
29 // HTTPNames.in.
30 const char kDevtoolsRequestId[] = "X-DevTools-Request-Id";
31
28 } // namespace 32 } // namespace
29 33
30 GenericURLRequestJob::GenericURLRequestJob( 34 GenericURLRequestJob::GenericURLRequestJob(
31 net::URLRequest* request, 35 net::URLRequest* request,
32 net::NetworkDelegate* network_delegate, 36 net::NetworkDelegate* network_delegate,
33 URLRequestDispatcher* url_request_dispatcher, 37 URLRequestDispatcher* url_request_dispatcher,
34 std::unique_ptr<URLFetcher> url_fetcher, 38 std::unique_ptr<URLFetcher> url_fetcher,
35 Delegate* delegate) 39 Delegate* delegate)
36 : ManagedDispatchURLRequestJob(request, 40 : ManagedDispatchURLRequestJob(request,
37 network_delegate, 41 network_delegate,
38 url_request_dispatcher), 42 url_request_dispatcher),
39 url_fetcher_(std::move(url_fetcher)), 43 url_fetcher_(std::move(url_fetcher)),
40 delegate_(delegate), 44 delegate_(delegate),
41 weak_factory_(this) {} 45 weak_factory_(this) {}
42 46
43 GenericURLRequestJob::~GenericURLRequestJob() = default; 47 GenericURLRequestJob::~GenericURLRequestJob() = default;
44 48
45 void GenericURLRequestJob::SetExtraRequestHeaders( 49 void GenericURLRequestJob::SetExtraRequestHeaders(
46 const net::HttpRequestHeaders& headers) { 50 const net::HttpRequestHeaders& headers) {
47 extra_request_headers_ = headers; 51 extra_request_headers_ = headers;
52
53 if (extra_request_headers_.GetHeader(kDevtoolsRequestId,
54 &devtools_request_id_)) {
55 extra_request_headers_.RemoveHeader(kDevtoolsRequestId);
56 }
48 } 57 }
49 58
50 void GenericURLRequestJob::Start() { 59 void GenericURLRequestJob::Start() {
51 auto callback = [this](RewriteResult result, const GURL& url, 60 auto callback = [this](RewriteResult result, const GURL& url,
52 const std::string& method) { 61 const std::string& method) {
53 switch (result) { 62 switch (result) {
54 case RewriteResult::kAllow: 63 case RewriteResult::kAllow:
55 // Note that we use the rewritten url for selecting cookies. 64 // Note that we use the rewritten url for selecting cookies.
56 // Also, rewriting does not affect the request initiator. 65 // Also, rewriting does not affect the request initiator.
57 PrepareCookies(url, method, url::Origin(url)); 66 PrepareCookies(url, method, url::Origin(url));
58 break; 67 break;
59 case RewriteResult::kDeny: 68 case RewriteResult::kDeny:
60 DispatchStartError(net::ERR_FILE_NOT_FOUND); 69 DispatchStartError(net::ERR_FILE_NOT_FOUND);
61 break; 70 break;
62 case RewriteResult::kFailure: 71 case RewriteResult::kFailure:
63 DispatchStartError(net::ERR_UNEXPECTED); 72 DispatchStartError(net::ERR_UNEXPECTED);
64 break; 73 break;
65 default: 74 default:
66 DCHECK(false); 75 DCHECK(false);
67 } 76 }
68 }; 77 };
69 78
70 if (!delegate_->BlockOrRewriteRequest(request_->url(), request_->method(), 79 if (!delegate_->BlockOrRewriteRequest(request_->url(), devtools_request_id_,
80 request_->method(),
71 request_->referrer(), callback)) { 81 request_->referrer(), callback)) {
72 PrepareCookies(request_->url(), request_->method(), 82 PrepareCookies(request_->url(), request_->method(),
73 url::Origin(request_->first_party_for_cookies())); 83 url::Origin(request_->first_party_for_cookies()));
74 } 84 }
75 } 85 }
76 86
77 void GenericURLRequestJob::PrepareCookies(const GURL& rewritten_url, 87 void GenericURLRequestJob::PrepareCookies(const GURL& rewritten_url,
78 const std::string& method, 88 const std::string& method,
79 const url::Origin& site_for_cookies) { 89 const url::Origin& site_for_cookies) {
80 net::CookieStore* cookie_store = request_->context()->cookie_store(); 90 net::CookieStore* cookie_store = request_->context()->cookie_store();
(...skipping 30 matching lines...) Expand all
111 // Pass cookies, the referrer and any extra headers into the fetch request. 121 // Pass cookies, the referrer and any extra headers into the fetch request.
112 extra_request_headers_.SetHeader( 122 extra_request_headers_.SetHeader(
113 net::HttpRequestHeaders::kCookie, 123 net::HttpRequestHeaders::kCookie,
114 net::CookieStore::BuildCookieLine(cookie_list)); 124 net::CookieStore::BuildCookieLine(cookie_list));
115 125
116 extra_request_headers_.SetHeader(net::HttpRequestHeaders::kReferer, 126 extra_request_headers_.SetHeader(net::HttpRequestHeaders::kReferer,
117 request_->referrer()); 127 request_->referrer());
118 128
119 // The resource may have been supplied in the request. 129 // The resource may have been supplied in the request.
120 const HttpResponse* matched_resource = delegate_->MaybeMatchResource( 130 const HttpResponse* matched_resource = delegate_->MaybeMatchResource(
121 rewritten_url, method, extra_request_headers_); 131 rewritten_url, devtools_request_id_, method, extra_request_headers_);
122 132
123 if (matched_resource) { 133 if (matched_resource) {
124 OnFetchCompleteExtractHeaders( 134 OnFetchCompleteExtractHeaders(
125 matched_resource->final_url, matched_resource->http_response_code, 135 matched_resource->final_url, matched_resource->http_response_code,
126 matched_resource->response_data, matched_resource->response_data_size); 136 matched_resource->response_data, matched_resource->response_data_size);
127 } else { 137 } else {
128 url_fetcher_->StartFetch(rewritten_url, method, extra_request_headers_, 138 url_fetcher_->StartFetch(rewritten_url, method, extra_request_headers_,
129 this); 139 this);
130 } 140 }
131 } 141 }
(...skipping 12 matching lines...) Expand all
144 http_response_code_ = http_response_code; 154 http_response_code_ = http_response_code;
145 response_headers_ = response_headers; 155 response_headers_ = response_headers;
146 body_ = body; 156 body_ = body;
147 body_size_ = body_size; 157 body_size_ = body_size;
148 158
149 DispatchHeadersComplete(); 159 DispatchHeadersComplete();
150 160
151 std::string mime_type; 161 std::string mime_type;
152 GetMimeType(&mime_type); 162 GetMimeType(&mime_type);
153 163
154 delegate_->OnResourceLoadComplete(final_url, mime_type, http_response_code); 164 delegate_->OnResourceLoadComplete(final_url, devtools_request_id_, mime_type,
165 http_response_code);
155 } 166 }
156 167
157 int GenericURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) { 168 int GenericURLRequestJob::ReadRawData(net::IOBuffer* buf, int buf_size) {
158 // TODO(skyostil): Implement ranged fetches. 169 // TODO(skyostil): Implement ranged fetches.
159 // TODO(alexclarke): Add coverage for all the cases below. 170 // TODO(alexclarke): Add coverage for all the cases below.
160 size_t bytes_available = body_size_ - read_offset_; 171 size_t bytes_available = body_size_ - read_offset_;
161 size_t bytes_to_copy = 172 size_t bytes_to_copy =
162 std::min(static_cast<size_t>(buf_size), bytes_available); 173 std::min(static_cast<size_t>(buf_size), bytes_available);
163 if (bytes_to_copy) { 174 if (bytes_to_copy) {
164 std::memcpy(buf->data(), &body_[read_offset_], bytes_to_copy); 175 std::memcpy(buf->data(), &body_[read_offset_], bytes_to_copy);
(...skipping 21 matching lines...) Expand all
186 return false; 197 return false;
187 return response_headers_->GetCharset(charset); 198 return response_headers_->GetCharset(charset);
188 } 199 }
189 200
190 void GenericURLRequestJob::GetLoadTimingInfo( 201 void GenericURLRequestJob::GetLoadTimingInfo(
191 net::LoadTimingInfo* load_timing_info) const { 202 net::LoadTimingInfo* load_timing_info) const {
192 // TODO(alexclarke): Investigate setting the other members too where possible. 203 // TODO(alexclarke): Investigate setting the other members too where possible.
193 load_timing_info->receive_headers_end = response_time_; 204 load_timing_info->receive_headers_end = response_time_;
194 } 205 }
195 206
207 bool GenericURLRequestJob::Delegate::BlockOrRewriteRequest(
208 const GURL& url,
209 const std::string& devtools_id,
210 const std::string& method,
211 const std::string& referrer,
212 RewriteCallback callback) {
213 return BlockOrRewriteRequest(url, method, referrer, callback);
214 }
215
216 bool GenericURLRequestJob::Delegate::BlockOrRewriteRequest(
217 const GURL& url,
218 const std::string& method,
219 const std::string& referrer,
220 RewriteCallback callback) {
221 return false;
222 }
223
224 const GenericURLRequestJob::HttpResponse*
225 GenericURLRequestJob::Delegate::MaybeMatchResource(
226 const GURL& url,
227 const std::string& devtools_id,
228 const std::string& method,
229 const net::HttpRequestHeaders& request_headers) {
230 return MaybeMatchResource(url, method, request_headers);
231 }
232
233 const GenericURLRequestJob::HttpResponse*
234 GenericURLRequestJob::Delegate::MaybeMatchResource(
235 const GURL& url,
236 const std::string& method,
237 const net::HttpRequestHeaders& request_headers) {
238 return nullptr;
239 }
240
241 void GenericURLRequestJob::Delegate::OnResourceLoadComplete(
242 const GURL& final_url,
243 const std::string& devtools_id,
244 const std::string& mime_type,
245 int http_response_code) {
246 OnResourceLoadComplete(final_url, mime_type, http_response_code);
247 }
248
196 } // namespace headless 249 } // namespace headless
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698