Add Network.setSendRequestIdHeader and use it in headless

chrome/browser/devtools/devtools_network_transaction.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_network_transaction.h"
 
 #include <utility>
 
 #include "base/callback_helpers.h"
 #include "chrome/browser/devtools/devtools_network_controller.h"
 #include "chrome/browser/devtools/devtools_network_interceptor.h"
 #include "chrome/browser/devtools/devtools_network_upload_data_stream.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_network_transaction.h"
 #include "net/http/http_request_info.h"
 #include "net/socket/connection_attempts.h"
 
 // Keep in sync with X_DevTools_Emulate_Network_Conditions_Client_Id defined in
-// HTTPNames.in.
+// HTTPNames.json5.
 const char
     DevToolsNetworkTransaction::kDevToolsEmulateNetworkConditionsClientId[] =
         "X-DevTools-Emulate-Network-Conditions-Client-Id";
 
+// Keep in sync with X_DevTools_Requestt_Id defined in HTTPNames.json5.

[Sami, 2017/02/27 12:39:07]

typo: request

[alex clarke (OOO till 29th), 2017/02/27 13:51:16]

Done.

+const char DevToolsNetworkTransaction::kDevToolsRequestId[] =
+    "X-DevTools-Request-Id";
+
 DevToolsNetworkTransaction::DevToolsNetworkTransaction(
     DevToolsNetworkController* controller,
     std::unique_ptr<net::HttpTransaction> network_transaction)
     : throttled_byte_count_(0),
       controller_(controller),
       network_transaction_(std::move(network_transaction)),
       request_(nullptr),
       failed_(false) {
   DCHECK(controller);
 }
@@ skipping 71 matching lines @@
 }
 
 int DevToolsNetworkTransaction::Start(const net::HttpRequestInfo* request,
                                       const net::CompletionCallback& callback,
                                       const net::NetLogWithSource& net_log) {
   DCHECK(request);
   request_ = request;
 
   std::string client_id;
   bool has_devtools_client_id = request_->extra_headers.HasHeader(
       kDevToolsEmulateNetworkConditionsClientId);

[Sami, 2017/02/27 12:39:07]

Should we also check for kDevToolsRequestId?

[alex clarke (OOO till 29th), 2017/02/27 13:51:16]

Possibly yes. Pavel WDYT?

   if (has_devtools_client_id) {
     custom_request_.reset(new net::HttpRequestInfo(*request_));
     custom_request_->extra_headers.GetHeader(
         kDevToolsEmulateNetworkConditionsClientId, &client_id);
     custom_request_->extra_headers.RemoveHeader(
         kDevToolsEmulateNetworkConditionsClientId);
+    custom_request_->extra_headers.RemoveHeader(kDevToolsRequestId);
 
     if (request_->upload_data_stream) {
       custom_upload_data_stream_.reset(
           new DevToolsNetworkUploadDataStream(request_->upload_data_stream));
       custom_request_->upload_data_stream = custom_upload_data_stream_.get();
     }
 
     request_ = custom_request_.get();
   }
 
@@ skipping 158 matching lines @@
   if (CheckFailed())
     return net::ERR_INTERNET_DISCONNECTED;
   return network_transaction_->ResumeNetworkStart();
 }
 
 void
 DevToolsNetworkTransaction::GetConnectionAttempts(net::ConnectionAttempts* out)
 const {
   network_transaction_->GetConnectionAttempts(out);
 }