Add a temporary crash key to debug nib loading issues.

chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 
 #include <algorithm>
 
+#include "base/debug/crash_logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 26 matching lines @@
 #import "chrome/browser/ui/cocoa/toolbar/app_toolbar_button.h"
 #import "chrome/browser/ui/cocoa/toolbar/app_toolbar_button_cell.h"
 #import "chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h"
 #import "chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/toolbar/app_menu_icon_controller.h"
 #include "chrome/browser/ui/toolbar/app_menu_model.h"
+#include "chrome/common/crash_keys.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/metrics/proto/omnibox_event.pb.h"
 #include "components/omnibox/browser/autocomplete_classifier.h"
 #include "components/omnibox/browser/autocomplete_match.h"
 #include "components/omnibox/browser/omnibox_edit_model.h"
 #include "components/omnibox/browser/omnibox_view.h"
 #include "components/prefs/pref_service.h"
@@ skipping 180 matching lines @@
 // Now we can hook up bridges that rely on UI objects such as the location bar
 // and button state. -viewDidLoad is the recommended way to do this in 10.10
 // SDK. When running on 10.10 or above -awakeFromNib still works but for some
 // reason is not guaranteed to be called (http://crbug.com/526276), so implement
 // both.
 - (void)awakeFromNib {
   [self viewDidLoad];
 }
 
 - (void)viewDidLoad {
+  base::debug::ScopedCrashKey nib_crash_key{
+      crash_keys::mac::kToolbarNibInfo, [&] {

[Robert Sesek, 2017/02/15 20:20:18]

I don't see any advantage of a lambda here. Can you just write this
straight-line?

[Sidney San Martín, 2017/02/15 22:45:19]

Trying not to leak locals. What would you do instead?

[Sidney San Martín, 2017/02/15 23:15:01]

I didn't change this yet (because I'm trying to keep locals contained, but LMK
if you'd still prefer straight line.

[Robert Sesek, 2017/02/16 00:25:16]

It's temporary code, so I don't feel strongly, but it's also temporary code so
why do the locals matter? (also not sure about all this use of auto, but again,
temporary code).

+        auto nibPath =
+            [self.nibBundle pathForResource:@"Toolbar" ofType:@"nib"];
+        auto closestPath = nibPath;
+        auto fileManager = [NSFileManager defaultManager];
+        while (closestPath && ![fileManager fileExistsAtPath:closestPath]) {

[Robert Sesek, 2017/02/15 20:20:18]

I would use actual stat on the nib file so that we can record errno. It would be
useful to know the difference between ENOENT and EACCESS, for example. And then
also record the closest path like you're doing here.

[Sidney San Martín, 2017/02/15 23:15:01]

Done, let me know if it makes sense.

+          closestPath = [closestPath stringByDeletingLastPathComponent];
+        }
+        return [NSString
+            stringWithFormat:@"nib: %@ closest: %@", nibPath, closestPath];
+      }().UTF8String};
+
   // When linking and running on 10.10+, both -awakeFromNib and -viewDidLoad may
   // be called, don't initialize twice.
   if (locationBarView_) {
     DCHECK(base::mac::IsAtLeastOS10_10());
     return;
   }
 
   BOOL isRTL = cocoa_l10n_util::ShouldDoExperimentalRTLLayout();
   NSAutoresizingMaskOptions leadingButtonMask =
       isRTL ? NSViewMinXMargin | NSViewMinYMargin
@@ skipping 820 matching lines @@
 - (void)hideDropURLsIndicatorInView:(NSView*)view {
   // Do nothing.
 }
 
 // (URLDropTargetController protocol)
 - (BOOL)isUnsupportedDropData:(id<NSDraggingInfo>)info {
   return drag_util::IsUnsupportedDropData(profile_, info);
 }
 
 @end