components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc - Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)

Patch Set: Remove dependency CL. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_profile_comparator.cc ('k') | components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

index b43f4fc3ed711922885bd756d610cb9808aef6b7..fc6948f1aef86fa1afb8ab1143b1bc20e38b1fd8 100644

--- a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

@@ -10,6 +10,7 @@

#include <utility>

#include "base/logging.h"

+#include "base/strings/string_piece.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/core/browser/webdata/autofill_table.h"

@@ -86,8 +87,8 @@ AutofillProfile ProfileFromSpecifics(

AutofillProfile profile(AutofillProfile::SERVER_PROFILE, std::string());

// AutofillProfile stores multi-line addresses with newline separators.

- std::vector<std::string> street_address(address.street_address().begin(),

- address.street_address().end());

+ std::vector<base::StringPiece> street_address(

+ address.street_address().begin(), address.street_address().end());

profile.SetRawInfo(ADDRESS_HOME_STREET_ADDRESS,

base::UTF8ToUTF16(base::JoinString(street_address, "\n")));