extensions/common/features/feature_provider.cc - Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/feature_provider.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)

Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/feature_provider.cc

diff --git a/extensions/common/features/feature_provider.cc b/extensions/common/features/feature_provider.cc

index 3c7b6a53c39e031c26d10d40ceb125185eb6ba8a..99213c7ff531dceb553c0b7da8cd6feaebf28165 100644

--- a/extensions/common/features/feature_provider.cc

+++ b/extensions/common/features/feature_provider.cc

@@ -140,7 +140,7 @@ Feature* FeatureProvider::GetParent(Feature* feature) const {

if (feature->no_parent())

return nullptr;

- std::vector<std::string> split = base::SplitString(

+ std::vector<base::StringPiece> split = base::SplitStringPiece(

feature->name(), ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (split.size() < 2)

return nullptr;