Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: components/nacl/renderer/platform_info.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/platform_info.cc
diff --git a/components/nacl/renderer/platform_info.cc b/components/nacl/renderer/platform_info.cc
index d4eba29c92f072eeefece4a547c0fb039dbdea6e..24111cede2c3214e25cee789487df45ce334573f 100644
--- a/components/nacl/renderer/platform_info.cc
+++ b/components/nacl/renderer/platform_info.cc
@@ -4,6 +4,7 @@
#include "base/cpu.h"
#include "base/logging.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#if defined(OS_WIN)
@@ -59,7 +60,7 @@ std::string GetCpuFeatures() {
// doesn't handle other architectures very well, and we
// should at least detect the presence of ARM's integer
// divide.
- std::vector<std::string> features;
+ std::vector<base::StringPiece> features;
base::CPU cpu;
// On x86, SSE features are ordered: the most recent one implies the

Powered by Google App Engine
This is Rietveld 408576698