chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc - Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)

Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/safe_search_util.cc ('K') | « chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('k') | chrome/common/extensions/command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

diff --git a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

index 103ea8be87dd26f51557c49b0469b70788f31e1e..b7f17f6b39dad5efa38a76369fd66973295aab40 100644

--- a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

+++ b/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc

@@ -26,6 +26,7 @@

#include "base/logging.h"

#include "base/macros.h"

#include "base/run_loop.h"

+#include "base/strings/string_piece.h"

#include "base/strings/string_util.h"

#include "base/time/time.h"

#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"

@@ -379,7 +380,7 @@ MultiUserWindowManagerChromeOSTest::GetOwnersOfVisibleWindowsAsString() {

std::set<AccountId> owners;

multi_user_window_manager_->GetOwnersOfVisibleWindows(&owners);

- std::vector<std::string> owner_list;

+ std::vector<base::StringPiece> owner_list;

for (auto& owner : owners)

owner_list.push_back(owner.GetUserEmail());

return base::JoinString(owner_list, " ");