Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc
diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
index 23b1832d56a59308d33986e8cf662ada86ec7e08..ee38b513c78aa1314fa88f23b5c17d2ca99192e4 100644
--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
@@ -29,6 +29,7 @@
#include "base/memory/singleton.h"
#include "base/metrics/histogram_macros.h"
#include "base/path_service.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/time/time.h"
@@ -991,12 +992,12 @@ void AccessibilityManager::UpdateBrailleImeState() {
if (!profile_)
return;
PrefService* pref_service = profile_->GetPrefs();
- std::vector<std::string> preload_engines =
- base::SplitString(pref_service->GetString(prefs::kLanguagePreloadEngines),
- ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
- std::vector<std::string>::iterator it =
- std::find(preload_engines.begin(),
- preload_engines.end(),
+ std::string preload_engines_str =
+ pref_service->GetString(prefs::kLanguagePreloadEngines);
+ std::vector<base::StringPiece> preload_engines = base::SplitStringPiece(
+ preload_engines_str, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+ std::vector<base::StringPiece>::iterator it =
+ std::find(preload_engines.begin(), preload_engines.end(),
extension_misc::kBrailleImeEngineId);
bool is_enabled = (it != preload_engines.end());
bool should_be_enabled =

Powered by Google App Engine
This is Rietveld 408576698