Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2966)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/trace_event/trace_log.cc

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/feature_list.cc ('K') | « base/test/launcher/test_launcher.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/extensions/chrome_content_verifier_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_log.cc
diff --git a/base/trace_event/trace_log.cc b/base/trace_event/trace_log.cc
index 6dddb94018f6e1b6ec0047f22460c2940399b076..5eb2461a8ba5554dbecd7a3d0d466ed8776dbddb 100644
--- a/base/trace_event/trace_log.cc
+++ b/base/trace_event/trace_log.cc
@@ -21,6 +21,7 @@
#include "base/message_loop/message_loop.h"
#include "base/process/process_metrics.h"
#include "base/stl_util.h"
+#include "base/strings/string_piece.h"
#include "base/strings/string_split.h"
#include "base/strings/string_tokenizer.h"
#include "base/strings/stringprintf.h"
@@ -1501,7 +1502,7 @@ void TraceLog::AddMetadataEventsWhileLocked() {
}
if (!process_labels_.empty()) {
- std::vector<std::string> labels;
+ std::vector<base::StringPiece> labels;
for (const auto& it : process_labels_)
labels.push_back(it.second);
InitializeMetadataEvent(AddEventToThreadSharedChunkWhileLocked(NULL, false),
« base/feature_list.cc ('K') | « base/test/launcher/test_launcher.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/extensions/chrome_content_verifier_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698