Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2899)

Unified Diff: base/feature_list.h

Issue 2695883003: Change uses of base::JoinString to pass StringPieces where possible. (Closed)
Patch Set: Fix android_webview compilation (and made FeatureList::SplitFeatureListString take StringPiece). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/feature_list.h
diff --git a/base/feature_list.h b/base/feature_list.h
index 09e8408aa843a9526b5b07be41726b4a08a05d08..c9f4a7b0c462805dfd622ef68317634bae251956 100644
--- a/base/feature_list.h
+++ b/base/feature_list.h
@@ -156,9 +156,10 @@ class BASE_EXPORT FeatureList {
// called after the singleton instance has been registered via SetInstance().
static FieldTrial* GetFieldTrial(const Feature& feature);
- // Splits a comma-separated string containing feature names into a vector.
- static std::vector<std::string> SplitFeatureListString(
- const std::string& input);
+ // Splits a comma-separated string containing feature names into a vector. The
+ // resulting pieces point to parts of |input|.
+ static std::vector<base::StringPiece> SplitFeatureListString(
+ base::StringPiece input);
// Initializes and sets an instance of FeatureList with feature overrides via
// command-line flags |enable_features| and |disable_features| if one has not

Powered by Google App Engine
This is Rietveld 408576698