Change uses of base::JoinString to pass StringPieces where possible.

remoting/base/capabilities_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/macros.h"
+#include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "remoting/base/capabilities.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 struct HasCapabilityTestData {
   const char* capabilities;
   const char* key;
@@ skipping 37 matching lines @@
     { "a b", "z", false },
     { "a b c", "", false },
     { "a b c", "a", true },
     { "a b c", "b", true },
     { "a b c", "z", false }
   };
 
   // Verify that HasCapability(|capabilities|, |key|) returns |result|.
   // |result|.
   for (size_t i = 0; i < arraysize(data); ++i) {
-    std::vector<std::string> caps = base::SplitString(
-        data[i].capabilities, " ", base::KEEP_WHITESPACE,
-        base::SPLIT_WANT_NONEMPTY);
+    std::vector<base::StringPiece> caps =
+        base::SplitStringPiece(data[i].capabilities, " ", base::KEEP_WHITESPACE,
+                               base::SPLIT_WANT_NONEMPTY);
     do {
       EXPECT_EQ(data[i].result,
                 HasCapability(base::JoinString(caps, " "), data[i].key));
     } while (std::next_permutation(caps.begin(), caps.end()));
   }
 }
 
 TEST(CapabilitiesTest, Intersect) {
   EXPECT_EQ(IntersectCapabilities("a", "a"), "a");
 
   IntersectTestData data[] = {
     { "", "", "" },
     { "a", "", "" },
     { "a", "a", "a" },
     { "a", "b", "" },
     { "a b", "", "" },
     { "a b", "a", "a" },
     { "a b", "b", "b" },
     { "a b", "z", "" },
     { "a b c", "a", "a" },
     { "a b c", "b", "b" },
     { "a b c", "a b", "a b" },
     { "a b c", "b a", "a b" },
     { "a b c", "z", "" }
   };
 
   // Verify that intersection of |right| with all permutations of |left| yields
   // |result|.
   for (size_t i = 0; i < arraysize(data); ++i) {
-    std::vector<std::string> caps = base::SplitString(
+    std::vector<base::StringPiece> caps = base::SplitStringPiece(
         data[i].left, " ", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
     do {
       EXPECT_EQ(data[i].result,
                 IntersectCapabilities(base::JoinString(caps, " "),
                                       data[i].right));
     } while (std::next_permutation(caps.begin(), caps.end()));
   }
 }
 
 }  // namespace remoting