Change uses of base::JoinString to pass StringPieces where possible.

google_apis/gaia/fake_gaia.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gaia/fake_gaia.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "net/base/url_util.h"
 #include "net/cookies/parsed_cookie.h"
 #include "net/http/http_status_code.h"
 #include "net/test/embedded_test_server/http_request.h"
@@ skipping 711 matching lines @@
   const AccessTokenInfo* token_info = NULL;
   std::string access_token;
   if (GetQueryParameter(request.content, "access_token", &access_token))
     token_info = GetAccessTokenInfo(access_token);
 
   if (token_info) {
     base::DictionaryValue response_dict;
     response_dict.SetString("issued_to", token_info->issued_to);
     response_dict.SetString("audience", token_info->audience);
     response_dict.SetString("user_id", token_info->user_id);
-    std::vector<std::string> scope_vector(token_info->scopes.begin(),
-                                          token_info->scopes.end());
+    std::vector<base::StringPiece> scope_vector(token_info->scopes.begin(),
+                                                token_info->scopes.end());
     response_dict.SetString("scope", base::JoinString(scope_vector, " "));
     response_dict.SetInteger("expires_in", token_info->expires_in);
     response_dict.SetString("email", token_info->email);
     FormatJSONResponse(response_dict, http_response);
   } else {
     http_response->set_code(net::HTTP_BAD_REQUEST);
   }
 }
 
 void FakeGaia::HandleIssueToken(const HttpRequest& request,
@@ skipping 82 matching lines @@
   http_response->AddCustomHeader("Google-Accounts-SAML", "Start");
   http_response->AddCustomHeader("Location", redirect_url);
 }
 
 void FakeGaia::HandleGetCheckConnectionInfo(
     const net::test_server::HttpRequest& request,
     net::test_server::BasicHttpResponse* http_response) {
   base::ListValue connection_list;
   FormatJSONResponse(connection_list, http_response);
 }