Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1717)

Unified Diff: chrome/browser/resources/local_ntp/local_ntp.js

Issue 2695813012: [Local NTP] Add an integration test for the most visited iframe (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/local_ntp.js
diff --git a/chrome/browser/resources/local_ntp/local_ntp.js b/chrome/browser/resources/local_ntp/local_ntp.js
index e547e3e590c894eb8f091cdde8b3a949c8c1239c..ca602f1840b143326b2084fdfe5446aa2ad4413a 100644
--- a/chrome/browser/resources/local_ntp/local_ntp.js
+++ b/chrome/browser/resources/local_ntp/local_ntp.js
@@ -340,7 +340,8 @@ function onMostVisitedChange() {
/**
- * Fetches new data, creates, and renders tiles.
+ * Fetches new data (RIDs) from the embeddedSearch.newTabPage API and passes
+ * them to the iframe.
*/
function reloadTiles() {
var pages = ntpApiHandle.mostVisited;
@@ -651,7 +652,7 @@ function init() {
var iframe = document.createElement('iframe');
iframe.id = IDS.TILES_IFRAME;
iframe.tabIndex = 1;
- iframe.src = '//most-visited/single.html?' + args.join('&');
+ iframe.src = 'chrome-search://most-visited/single.html?' + args.join('&');
Marc Treib 2017/02/17 17:25:31 This change is necessary for the fake testing NTP
$(IDS.TILES).appendChild(iframe);
iframe.onload = function() {
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_test_utils.h » ('j') | chrome/browser/ui/search/instant_test_utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698