Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html

Issue 2695813009: Import wpt@503f5b5f78ec4e87d144f78609f363f0ed0ea8db (Closed)
Patch Set: Skip some tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html
index d2ed677e6d011c9cf3aeb22a7bbf8cdb5d5e4b61..b66d4a821861b6e6e37e47b652f32756c8062058 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https.html
@@ -21,16 +21,10 @@ promise_test(t => {
.then(_ => with_iframe(scope))
.then(f => {
frame = f;
- return Promise.all([
- // This will get effectively an empty service worker FetchEvent
- // handler. It should have no additional delay. Note that the
- // text() call is necessary to complete the response and have the
- // timings show up in the performance entries.
- frame.contentWindow.fetch(url).then(r => r && r.text()),
- // This will cause the service worker to spin for two seconds
- // in its FetchEvent handler.
- frame.contentWindow.fetch(slowURL).then(r => r && r.text())
- ]);
+ return frame.contentWindow.fetch(url).then(r => r && r.text());
+ })
+ .then(_ => {
+ return frame.contentWindow.fetch(slowURL).then(r => r && r.text());
})
.then(_ => {
function elapsed(u) {
@@ -42,7 +36,7 @@ promise_test(t => {
// Verify the request slowed by the service worker is indeed measured
// to be slower. Note, we compare to smaller delay instead of the exact
// delay amount to avoid making the test racy under automation.
- assert_true(slowURLTime >= urlTime + 1500,
+ assert_greater_than(slowURLTime, urlTime + 1000,
'Slow service worker request should measure increased delay.');
frame.remove();
return service_worker_unregister_and_done(t, scope);

Powered by Google App Engine
This is Rietveld 408576698