Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/ntp_tiles/icon_cacher_impl.h

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/icon_cacher.h ('k') | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/icon_cacher_impl.h
diff --git a/components/ntp_tiles/icon_cacher_impl.h b/components/ntp_tiles/icon_cacher_impl.h
index 1028f72b29b7153cdd64706eaa4bc3623de11b41..20c5922f89ff46a116589a55c30ec4862d1c34a0 100644
--- a/components/ntp_tiles/icon_cacher_impl.h
+++ b/components/ntp_tiles/icon_cacher_impl.h
@@ -39,19 +39,24 @@ class IconCacherImpl : public IconCacher {
~IconCacherImpl() override;
void StartFetch(PopularSites::Site site,
- const base::Callback<void(bool)>& done) override;
+ const base::Closure& icon_available,
+ const base::Closure& preliminary_icon_available) override;
private:
void OnGetFaviconImageForPageURLFinished(
PopularSites::Site site,
- const base::Callback<void(bool)>& done,
+ const base::Closure& icon_available,
+ const base::Closure& preliminary_icon_available,
const favicon_base::FaviconImageResult& result);
void OnFaviconDownloaded(PopularSites::Site site,
- const base::Callback<void(bool)>& done,
+ const base::Closure& icon_available,
const std::string& id,
const gfx::Image& fetched_image);
+ bool ProvideDefaultIcon(const PopularSites::Site& site);
+ void SaveIconForSite(const PopularSites::Site& site, const gfx::Image image);
+
base::CancelableTaskTracker tracker_;
favicon::FaviconService* const favicon_service_;
std::unique_ptr<image_fetcher::ImageFetcher> const image_fetcher_;
« no previous file with comments | « components/ntp_tiles/icon_cacher.h ('k') | components/ntp_tiles/icon_cacher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698