Add baked-in favicons for default popular sites on NTP

components/ntp_tiles/popular_sites_impl_unittest.cc

Index: components/ntp_tiles/popular_sites_impl_unittest.cc
diff --git a/components/ntp_tiles/popular_sites_impl_unittest.cc b/components/ntp_tiles/popular_sites_impl_unittest.cc
index 6732e27cc0cca77c40ede17e986c36bc0622432b..1e80a63b406266fb05c7a5e77ad173ba62b1164e 100644
--- a/components/ntp_tiles/popular_sites_impl_unittest.cc
+++ b/components/ntp_tiles/popular_sites_impl_unittest.cc
@@ -234,6 +234,18 @@ TEST_F(PopularSitesTest, PopulatesWithDefaultResoucesOnFailure) {
   EXPECT_THAT(sites.size(), Eq(GetNumberOfDefaultPopularSitesForPlatform()));
 }
 
+TEST_F(PopularSitesTest, AddsIconResourcesToDefaultPages) {
+  scoped_refptr<net::TestURLRequestContextGetter> url_request_context(
+      new net::TestURLRequestContextGetter(
+          base::ThreadTaskRunnerHandle::Get()));
+  std::unique_ptr<PopularSites> popular_sites =
+      CreatePopularSites(url_request_context.get());
+
+  for (const auto& site : popular_sites->sites()) {

[mastiz, 2017/03/01 08:48:12]

Perhaps ASSERT the list is non-empty, just in case?

[fhorschig, 2017/03/01 20:57:36]

Done.

+    EXPECT_TRUE(site.default_resource_id > 0);

[mastiz, 2017/03/01 08:48:12]

Nit: EXPECT_THAT(...resource_id, Gt(0));

[fhorschig, 2017/03/01 20:57:36]

Done.

+  }
+}
+
 TEST_F(PopularSitesTest, ProvidesDefaultSitesUntilCallbackReturns) {
   SetCountryAndVersion("ZZ", "9");
   RespondWithJSON(