Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3362)

Unified Diff: chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
diff --git a/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc b/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
index 8ddd03b4997b47441040d5888f3de9ab5f89a6a9..1e4c32724bd246c697938a826dd04811bd4198bf 100644
--- a/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
+++ b/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
@@ -8,6 +8,7 @@
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/common/chrome_paths.h"
@@ -22,6 +23,9 @@ ChromePopularSitesFactory::NewForProfile(Profile* profile) {
return base::MakeUnique<ntp_tiles::PopularSitesImpl>(
content::BrowserThread::GetBlockingPool(), profile->GetPrefs(),
TemplateURLServiceFactory::GetForProfile(profile),
- g_browser_process->variations_service(), profile->GetRequestContext(),
- directory, base::Bind(safe_json::SafeJsonParser::Parse));
+ g_browser_process->variations_service(),
+ FaviconServiceFactory::GetForProfile(profile,
+ ServiceAccessType::IMPLICIT_ACCESS),
+ profile->GetRequestContext(), directory,
+ base::Bind(safe_json::SafeJsonParser::Parse));
}
« no previous file with comments | « no previous file | components/ntp_tiles/most_visited_sites_unittest.cc » ('j') | components/ntp_tiles/popular_sites_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698