Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Side by Side Diff: components/resources/ntp_tiles_resources.grdp

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Have python script adhere to guidelines Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <grit-part> 2 <grit-part>
3 <if expr="is_android or is_ios"> 3 <if expr="is_android or is_ios">
4 <include name="IDR_POPULAR_SITES_INTERNALS_HTML" file="../ntp_tiles/webui/re sources/popular_sites_internals.html" flattenhtml="true" allowexternalscript="tr ue" type="BINDATA" /> 4 <include name="IDR_POPULAR_SITES_INTERNALS_HTML" file="../ntp_tiles/webui/re sources/popular_sites_internals.html" flattenhtml="true" allowexternalscript="tr ue" type="BINDATA" />
5 <include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/reso urces/popular_sites_internals.js" type="BINDATA" /> 5 <include name="IDR_POPULAR_SITES_INTERNALS_JS" file="../ntp_tiles/webui/reso urces/popular_sites_internals.js" type="BINDATA" />
6 <include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/res ources/popular_sites_internals.css" type="BINDATA" /> 6 <include name="IDR_POPULAR_SITES_INTERNALS_CSS" file="../ntp_tiles/webui/res ources/popular_sites_internals.css" type="BINDATA" />
7 <include name="IDR_DEFAULT_POPULAR_SITES_JSON" file="../ntp_tiles/resources/ default_popular_sites.json" type="BINDATA" /> 7 <include name="IDR_DEFAULT_POPULAR_SITES_JSON" file="../ntp_tiles/resources/ default_popular_sites.json" type="BINDATA" />
8 <include name="IDR_DEFAULT_POPULAR_SITES_ICON0" file="../ntp_tiles/resources /icon0" type="BINDATA" />
sfiera 2017/02/16 11:14:23 They have extensions now, right?
fhorschig 2017/02/16 17:06:42 Right. Added.
9 <include name="IDR_DEFAULT_POPULAR_SITES_ICON1" file="../ntp_tiles/resources /icon1" type="BINDATA" />
10 <include name="IDR_DEFAULT_POPULAR_SITES_ICON2" file="../ntp_tiles/resources /icon2" type="BINDATA" />
11 <include name="IDR_DEFAULT_POPULAR_SITES_ICON3" file="../ntp_tiles/resources /icon3" type="BINDATA" />
12 <include name="IDR_DEFAULT_POPULAR_SITES_ICON4" file="../ntp_tiles/resources /icon4" type="BINDATA" />
13 <include name="IDR_DEFAULT_POPULAR_SITES_ICON5" file="../ntp_tiles/resources /icon5" type="BINDATA" />
14 <include name="IDR_DEFAULT_POPULAR_SITES_ICON6" file="../ntp_tiles/resources /icon6" type="BINDATA" />
15 <include name="IDR_DEFAULT_POPULAR_SITES_ICON7" file="../ntp_tiles/resources /icon7" type="BINDATA" />
8 </if> 16 </if>
9 <include name="IDR_NTP_TILES_INTERNALS_HTML" file="../ntp_tiles/webui/resource s/ntp_tiles_internals.html" flattenhtml="true" allowexternalscript="true" type=" BINDATA" /> 17 <include name="IDR_NTP_TILES_INTERNALS_HTML" file="../ntp_tiles/webui/resource s/ntp_tiles_internals.html" flattenhtml="true" allowexternalscript="true" type=" BINDATA" />
10 <include name="IDR_NTP_TILES_INTERNALS_JS" file="../ntp_tiles/webui/resources/ ntp_tiles_internals.js" type="BINDATA" /> 18 <include name="IDR_NTP_TILES_INTERNALS_JS" file="../ntp_tiles/webui/resources/ ntp_tiles_internals.js" type="BINDATA" />
11 <include name="IDR_NTP_TILES_INTERNALS_CSS" file="../ntp_tiles/webui/resources /ntp_tiles_internals.css" type="BINDATA" /> 19 <include name="IDR_NTP_TILES_INTERNALS_CSS" file="../ntp_tiles/webui/resources /ntp_tiles_internals.css" type="BINDATA" />
12 </grit-part> 20 </grit-part>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698