Add baked-in favicons for default popular sites on NTP

components/ntp_tiles/popular_sites_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_tiles/popular_sites_impl.h"
 
 #include <map>
 #include <string>
+#include <unordered_set>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/important_file_writer.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/test/sequenced_worker_pool_owner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/values.h"
+#include "components/ntp_tiles/icon_cacher.h"
 #include "components/ntp_tiles/json_unsafe_parser.h"
 #include "components/ntp_tiles/pref_names.h"
 #include "components/ntp_tiles/switches.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/sync_preferences/testing_pref_service_syncable.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_status.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 22 matching lines @@
 }
 
 size_t GetNumberOfDefaultPopularSitesForPlatform() {
 #if defined(OS_ANDROID) || defined(OS_IOS)
   return 8ul;
 #else
   return 0;
 #endif
 }
 
+class FakeIconCacher : public IconCacher {
+ public:
+  FakeIconCacher() {}
+  ~FakeIconCacher() override {}
+
+  void StartFetch(PopularSites::Site site,
+                  const base::Callback<void(bool)>& done) override {}
+
+  void AddDefaultImage(const PopularSites::Site& site,
+                       int image_resource_id) override {
+    registered_sites_.insert(site.url.spec());
+  }
+
+  size_t GetRegisteredSitesCount() const { return registered_sites_.size(); }
+
+ private:
+  std::unordered_set<std::string> registered_sites_;
+};
+
 class PopularSitesTest : public ::testing::Test {
  protected:
   PopularSitesTest()
       : kWikipedia{
             {kTitle, "Wikipedia, fhta Ph'nglui mglw'nafh"},
             {kUrl, "https://zz.m.wikipedia.org/"},
             {kLargeIconUrl, "https://zz.m.wikipedia.org/wikipedia.png"},
         },
         kYouTube{
             {kTitle, "YouTube"},
@@ skipping 151 matching lines @@
       "https://www.gstatic.com/chrome/ntp/suggested_sites_ZZ_9.json");
   RespondWith404(
       "https://www.gstatic.com/chrome/ntp/suggested_sites_DEFAULT_5.json");
 
   PopularSites::SitesVector sites;
   EXPECT_THAT(FetchPopularSites(/*force_download=*/false, &sites),
               Eq(base::Optional<bool>(false)));
   EXPECT_THAT(sites.size(), Eq(GetNumberOfDefaultPopularSitesForPlatform()));
 }
 
+TEST_F(PopularSitesTest, AddsIconUrlsToIconCacher) {
+  auto icon_cacher = base::MakeUnique<FakeIconCacher>();
+  PopularSitesImpl::AddIconsForDefaultPagesToCacher(prefs_, icon_cacher.get());
+  EXPECT_THAT(icon_cacher->GetRegisteredSitesCount(),
+              Eq(GetNumberOfDefaultPopularSitesForPlatform()));
+}
+
 TEST_F(PopularSitesTest, ProvidesDefaultSitesUntilCallbackReturns) {
   SetCountryAndVersion("ZZ", "9");
   RespondWithJSON(
       "https://www.gstatic.com/chrome/ntp/suggested_sites_ZZ_9.json",
       {kWikipedia});
   scoped_refptr<net::TestURLRequestContextGetter> url_request_context(
       new net::TestURLRequestContextGetter(
           base::ThreadTaskRunnerHandle::Get()));
   std::unique_ptr<PopularSites> popular_sites =
       CreatePopularSites(url_request_context.get());
@@ skipping 168 matching lines @@
       "https://www.gstatic.com/chrome/ntp/suggested_sites_ZZ_9.json",
       {kChromium});
   EXPECT_THAT(FetchPopularSites(/*force_download=*/false, &sites),
               Eq(base::Optional<bool>(true)));
   ASSERT_THAT(sites.size(), Eq(1u));
   EXPECT_THAT(sites[0].url, URLEq("https://www.chromium.org/"));
 }
 
 }  // namespace
 }  // namespace ntp_tiles