Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: components/ntp_tiles/most_visited_sites.h

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_ 5 #ifndef COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_
6 #define COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_ 6 #define COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 // Takes the personal tiles, creates and merges in whitelist and popular tiles 174 // Takes the personal tiles, creates and merges in whitelist and popular tiles
175 // if appropriate, and saves the new tiles. 175 // if appropriate, and saves the new tiles.
176 void SaveNewTiles(NTPTilesVector personal_tiles); 176 void SaveNewTiles(NTPTilesVector personal_tiles);
177 177
178 // Notifies the observer about the availability of tiles. 178 // Notifies the observer about the availability of tiles.
179 // Also records impressions UMA if not done already. 179 // Also records impressions UMA if not done already.
180 void NotifyMostVisitedURLsObserver(); 180 void NotifyMostVisitedURLsObserver();
181 181
182 void OnPopularSitesDownloaded(bool success); 182 void OnPopularSitesDownloaded(bool success);
183 183
184 void OnIconMadeAvailable(const GURL& site_url, bool newly_available); 184 void OnIconMadeAvailable(const GURL& site_url);
185 185
186 // history::TopSitesObserver implementation. 186 // history::TopSitesObserver implementation.
187 void TopSitesLoaded(history::TopSites* top_sites) override; 187 void TopSitesLoaded(history::TopSites* top_sites) override;
188 void TopSitesChanged(history::TopSites* top_sites, 188 void TopSitesChanged(history::TopSites* top_sites,
189 ChangeReason change_reason) override; 189 ChangeReason change_reason) override;
190 190
191 PrefService* prefs_; 191 PrefService* prefs_;
192 scoped_refptr<history::TopSites> top_sites_; 192 scoped_refptr<history::TopSites> top_sites_;
193 suggestions::SuggestionsService* suggestions_service_; 193 suggestions::SuggestionsService* suggestions_service_;
194 std::unique_ptr<PopularSites> const popular_sites_; 194 std::unique_ptr<PopularSites> const popular_sites_;
(...skipping 20 matching lines...) Expand all
215 // For callbacks may be run after destruction, used exclusively for TopSites 215 // For callbacks may be run after destruction, used exclusively for TopSites
216 // (since it's used to detect whether there's a query in flight). 216 // (since it's used to detect whether there's a query in flight).
217 base::WeakPtrFactory<MostVisitedSites> top_sites_weak_ptr_factory_; 217 base::WeakPtrFactory<MostVisitedSites> top_sites_weak_ptr_factory_;
218 218
219 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites); 219 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
220 }; 220 };
221 221
222 } // namespace ntp_tiles 222 } // namespace ntp_tiles
223 223
224 #endif // COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_ 224 #endif // COMPONENTS_NTP_TILES_MOST_VISITED_SITES_H_
OLDNEW
« no previous file with comments | « components/ntp_tiles/icon_cacher_impl_unittest.cc ('k') | components/ntp_tiles/most_visited_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698