components/ntp_tiles/resources/default_popular_sites.json - Issue 2695713004: Add baked-in favicons for default popular sites on NTP

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_tiles/resources/default_popular_sites.json

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)

Patch Set: Add default resource attribute to Site Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_tiles/popular_sites_impl.cc ('K') | « components/ntp_tiles/popular_sites_impl_unittest.cc ('k') | components/ntp_tiles/resources/icon0.png » ('j') | components/ntp_tiles/update_default_sites_resources.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [{"url":"https://m.facebook.com/","title":"Facebook - Log In or Sign Up","large_ icon_url":"https://static.xx.fbcdn.net/rsrc.php/v3/ya/r/O2aKM2iSbOw.png"},{"url" :"https://m.youtube.com/","title":"YouTube","large_icon_url":"https://s.ytimg.co m/yts/mobile/img/apple-touch-icon-144x144-precomposed-vflwq-hLZ.png"},{"url":"ht tps://www.amazon.com/","title":"Amazon.com: Online Shopping for Electronics, App arel, Computers, Books, DVDs & more","large_icon_url":"https://images-na.ssl-ima ges-amazon.com/images/G/01/anywhere/a_smile_196x196._CB368246573_.png"},{"url":" https://en.m.wikipedia.org/","title":"Wikipedia, the free encyclopedia","large_i con_url":"https://en.m.wikipedia.org/static/apple-touch/wikipedia.png"},{"url":" http://www.espn.com/","title":"ESPN: The Worldwide Leader in Sports","large_icon _url":"http://a.espncdn.com/wireless/mw5/r1/images/bookmark-icons/espn_icon-152x 152.min.png"},{"url":"https://www.yahoo.com/","title":"Yahoo","large_icon_url":" https://s.yimg.com/dh/ap/default/130909/y_200_a.png"},{"url":"https://www.instag ram.com/","title":"Instagram","large_icon_url":"https://instagramstatic-a.akamai hd.net/h1/images/ico/favicon-192.png/b407fa101800.png"},{"url":"http://m.ebay.co m/","title":"Electronics, Cars, Fashion, Collectibles, Coupons and More \| eBay", "large_icon_url":"http://ir.ebaystatic.com/pictures/aw/pics/mobile/images/apple- touch-icon.png"}]

2 {

3 "title": "Facebook - Log In or Sign Up",

4 "url": "https://m.facebook.com/",

5 "large_icon_url": "https://static.xx.fbcdn.net/rsrc.php/v3/ya/r/O2aKM2iSbOw. png"

6 },

7 {

8 "title": "YouTube",

9 "url": "https://m.youtube.com/",

10 "large_icon_url": "https://s.ytimg.com/yts/mobile/img/apple-touch-icon-144x1 44-precomposed-vflwq-hLZ.png"

11 },

12 {

13 "title": "Amazon.com: Online Shopping for Electronics, Apparel, Computers, B ooks, DVDs \u0026 more",

14 "url": "https://www.amazon.com/",

15 "large_icon_url": "https://images-na.ssl-images-amazon.com/images/G/01/anywh ere/a_smile_196x196._CB368246573_.png"

16 },

17 {

18 "title": "Wikipedia, the free encyclopedia",

19 "url": "https://en.m.wikipedia.org/",

20 "large_icon_url": "https://en.m.wikipedia.org/static/apple-touch/wikipedia.p ng"

21 },

22 {

23 "title": "ESPN: The Worldwide Leader in Sports",

24 "url": "http://www.espn.com/",

25 "large_icon_url": "http://a.espncdn.com/wireless/mw5/r1/images/bookmark-icon s/espn_icon-152x152.min.png"

26 },

27 {

28 "title": "Yahoo",

29 "url": "https://www.yahoo.com/",

30 "large_icon_url": "https://s.yimg.com/dh/ap/default/130909/y_200_a.png"

31 },

32 {

33 "title": "Instagram",

34 "url": "https://www.instagram.com/",

35 "large_icon_url": "https://instagramstatic-a.akamaihd.net/h1/images/ico/favi con-192.png/b407fa101800.png"

36 },

37 {

38 "title": "Electronics, Cars, Fashion, Collectibles, Coupons and More \| eBay" ,

39 "url": "http://m.ebay.com/",

40 "large_icon_url": "http://ir.ebaystatic.com/pictures/aw/pics/mobile/images/a pple-touch-icon.png"

41 }

42 ]

OLD	NEW