Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: components/ntp_tiles/most_visited_sites_unittest.cc

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_tiles/most_visited_sites.h" 5 #include "components/ntp_tiles/most_visited_sites.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <ostream> 10 #include <ostream>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 }, 227 },
228 ])", 228 ])",
229 net::HTTP_OK, net::URLRequestStatus::SUCCESS); 229 net::HTTP_OK, net::URLRequestStatus::SUCCESS);
230 } 230 }
231 } 231 }
232 232
233 std::unique_ptr<PopularSites> New() { 233 std::unique_ptr<PopularSites> New() {
234 return base::MakeUnique<PopularSitesImpl>( 234 return base::MakeUnique<PopularSitesImpl>(
235 worker_pool_owner_.pool().get(), prefs_, 235 worker_pool_owner_.pool().get(), prefs_,
236 /*template_url_service=*/nullptr, 236 /*template_url_service=*/nullptr,
237 /*variations_service=*/nullptr, url_request_context_.get(), 237 /*variations_service=*/nullptr,
238 /*favicon_service=*/nullptr, url_request_context_.get(),
238 /*directory=*/base::FilePath(), base::Bind(JsonUnsafeParser::Parse)); 239 /*directory=*/base::FilePath(), base::Bind(JsonUnsafeParser::Parse));
239 } 240 }
240 241
241 private: 242 private:
242 PrefService* prefs_; 243 PrefService* prefs_;
243 net::FakeURLFetcherFactory url_fetcher_factory_; 244 net::FakeURLFetcherFactory url_fetcher_factory_;
244 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_; 245 scoped_refptr<net::TestURLRequestContextGetter> url_request_context_;
245 base::SequencedWorkerPoolOwner worker_pool_owner_; 246 base::SequencedWorkerPoolOwner worker_pool_owner_;
246 }; 247 };
247 248
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 MatchesTile("Site 4", "https://www.site4.com/", 806 MatchesTile("Site 4", "https://www.site4.com/",
806 NTPTileSource::TOP_SITES), 807 NTPTileSource::TOP_SITES),
807 MatchesTile("Site 1", "https://www.site1.com/", 808 MatchesTile("Site 1", "https://www.site1.com/",
808 NTPTileSource::POPULAR), 809 NTPTileSource::POPULAR),
809 MatchesTile("Site 2", "https://www.site2.com/", 810 MatchesTile("Site 2", "https://www.site2.com/",
810 NTPTileSource::POPULAR))); 811 NTPTileSource::POPULAR)));
811 } 812 }
812 813
813 } // namespace 814 } // namespace
814 } // namespace ntp_tiles 815 } // namespace ntp_tiles
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698