Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 2695663003: Remove last usages of ScopedVector in extensions/ (Closed)
Patch Set: remove rest of the (unused) includes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/language_options_handler_common.cc
diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc
index d41b05436ab2425bb3a1cdbfa4c7d1ddafdf5193..4b6b396d7681a8deabd0ea907868aaff646e8301 100644
--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc
+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc
@@ -131,7 +131,7 @@ void LanguageOptionsHandlerCommon::Uninitialize() {
if (!service)
return;
- for (auto* dict : service->GetHunspellDictionaries())
+ for (const auto& dict : service->GetHunspellDictionaries())
dict->RemoveObserver(this);
}
@@ -210,7 +210,7 @@ void LanguageOptionsHandlerCommon::LanguageOptionsOpenCallback(
if (!service)
return;
- for (auto* dictionary : service->GetHunspellDictionaries()) {
+ for (const auto& dictionary : service->GetHunspellDictionaries()) {
dictionary->RemoveObserver(this);
dictionary->AddObserver(this);
@@ -249,7 +249,7 @@ void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback(
if (!service)
return;
- for (auto* dictionary : service->GetHunspellDictionaries()) {
+ for (const auto& dictionary : service->GetHunspellDictionaries()) {
dictionary->RemoveObserver(this);
dictionary->AddObserver(this);
}
@@ -283,7 +283,7 @@ void LanguageOptionsHandlerCommon::RetrySpellcheckDictionaryDownload(
if (!service)
return;
- for (auto* dictionary : service->GetHunspellDictionaries()) {
+ for (const auto& dictionary : service->GetHunspellDictionaries()) {
if (dictionary->GetLanguage() == language) {
dictionary->RetryDownloadDictionary(
Profile::FromWebUI(web_ui())->GetRequestContext());

Powered by Google App Engine
This is Rietveld 408576698