chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc - Issue 2695663003: Remove last usages of ScopedVector in extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

Issue 2695663003: Remove last usages of ScopedVector in extensions/ (Closed)

Patch Set: remove rest of the (unused) includes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc ('k') | chrome/browser/spellchecker/spellcheck_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc b/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

index e04cfb041b117837b25731129ed830418c68b582..ef36126f785a165890da3c223d9406a228b78ddb 100644

--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc

@@ -11,7 +11,6 @@

#include "base/bind.h"

#include "base/bind_helpers.h"

-#include "base/memory/scoped_vector.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -179,9 +178,9 @@ void LanguageSettingsPrivateDelegate::RefreshDictionaries(

if (!custom_dictionary_)

custom_dictionary_ = service->GetCustomDictionary();

- const ScopedVector<SpellcheckHunspellDictionary>& dictionaries(

- service->GetHunspellDictionaries());

- for (auto* dictionary : dictionaries) {

+ const std::vector<std::unique_ptr<SpellcheckHunspellDictionary>>&

+ dictionaries(service->GetHunspellDictionaries());

+ for (const auto& dictionary : dictionaries) {

hunspell_dictionaries_.push_back(dictionary->AsWeakPtr());

if (should_listen)

dictionary->AddObserver(this);