[Web Payments] Add a mechanism to build item lists in the PR dialog.

chrome/browser/ui/views/payments/payment_request_sheet_controller.h

Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.h
diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
index d7c73e7f60f20b8224ca6e4684f44c2af80d1eeb..2ccdf3314aeeb3f40e846252bc8d9df98a5bde13 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
@@ -52,9 +52,19 @@ class PaymentRequestSheetController : public views::VectorIconButtonDelegate {
   // button should be displayed. The caller takes ownership of the button but
   // the view is guaranteed to be outlived by the controller so subclasses may
   // retain a raw pointer to the returned button (for example to control its
-  // enabled state).
+  // enabled state). See comment on CreatePaymentView for an illustration of the

[please use gerrit instead, 2017/02/22 20:26:28]

To ease the job of readers of code, it's a good idea to reduce the amount of
code to read in order to understand what this method does. This code returns a
button with either "pay" or "done" label. That should be sufficient to
understand this particular method. Therefore, there's no need to point to
another method that does overall layoyt.

[anthonyvd, 2017/02/22 20:55:06]

Done.

+  // layout.
   virtual std::unique_ptr<views::Button> CreatePrimaryButton();
 
+  // Creates and returns the view to be displayed next to the "Pay" and "Cancel"
+  // buttons. May return an empty std::unique_ptr (nullptr) to indicate that no
+  // extra view is to be displayed.The caller takes ownership of the view but
+  // the view is guaranteed to be outlived by the controller so subclasses may
+  // retain a raw pointer to the returned view (for example to control its
+  // enabled state). See comment on CreatePaymentView for an illustration of the
+  // layout.

[please use gerrit instead, 2017/02/22 20:26:28]

In the spirit of making this method understable as a single unit of code, please
provide ASCII wireframe of the structure of the returned view. No need to point
to other methods.

[anthonyvd, 2017/02/22 20:55:06]

Done.

+  virtual std::unique_ptr<views::View> CreateExtraView();
+
   // views::VectorIconButtonDelegate:
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
@@ -71,7 +81,7 @@ class PaymentRequestSheetController : public views::VectorIconButtonDelegate {
   // |          CONTENT          |
   // |           VIEW            |
   // +---------------------------+
-  // |            | CANCEL | PAY | <-- footer
+  // | EXTRA VIEW | PAY | CANCEL | <-- footer
   // +---------------------------+
   std::unique_ptr<views::View> CreatePaymentView(
       std::unique_ptr<views::View> header_view,