Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Issue 2695653004: [Web Payments] Add a mechanism to build item lists in the PR dialog. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
index 9b4e7e9778c7cb473b2522b76fca835a61ab529c..edcb19c19a314e35e48952c9e0cb74d7bfd6be7a 100644
--- a/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
@@ -19,7 +19,6 @@
#include "chrome/browser/ui/views/payments/payment_request_row_view.h"
#include "chrome/browser/ui/views/payments/payment_request_views_util.h"
#include "chrome/grit/generated_resources.h"
-#include "components/autofill/core/browser/autofill_data_util.h"
#include "components/autofill/core/browser/autofill_type.h"
#include "components/autofill/core/browser/credit_card.h"
#include "components/autofill/core/browser/field_types.h"
@@ -29,7 +28,6 @@
#include "components/strings/grit/components_strings.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/font.h"
#include "ui/gfx/paint_vector_icon.h"
@@ -304,11 +302,10 @@ std::unique_ptr<views::Button> PaymentSheetViewController::CreateShippingRow() {
// +----------------------------------------------+
std::unique_ptr<views::Button>
PaymentSheetViewController::CreatePaymentMethodRow() {
- autofill::CreditCard* selected_card =
- request()->GetCurrentlySelectedCreditCard();
+ autofill::CreditCard* selected_card = request()->selected_credit_card();
std::unique_ptr<views::View> content_view;
- std::unique_ptr<views::ImageView> card_icon_view;
+ std::unique_ptr<views::View> card_icon_view;
if (selected_card) {
content_view = base::MakeUnique<views::View>();
@@ -326,18 +323,7 @@ PaymentSheetViewController::CreatePaymentMethodRow() {
autofill::AutofillType(autofill::CREDIT_CARD_NAME_FULL),
g_browser_process->GetApplicationLocale())));
- card_icon_view = base::MakeUnique<views::ImageView>();
- card_icon_view->set_interactive(false);
- card_icon_view->SetImage(
- ResourceBundle::GetSharedInstance()
- .GetImageNamed(autofill::data_util::GetPaymentRequestData(
- selected_card->type()).icon_resource_id)
- .AsImageSkia());
- card_icon_view->SetBorder(
- views::CreateRoundedRectBorder(1, 3, SK_ColorLTGRAY));
-
- constexpr gfx::Size kCardIconSize = gfx::Size(32, 20);
- card_icon_view->SetImageSize(kCardIconSize);
+ card_icon_view = CreateCreditCardIconView(selected_card);
}
std::unique_ptr<views::Button> section = CreatePaymentSheetRow(

Powered by Google App Engine
This is Rietveld 408576698