[Web Payments] Add a mechanism to build item lists in the PR dialog.

components/payments/payment_request.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/payment_request.h"
 
 #include "base/memory/ptr_util.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/payments/payment_details_validation.h"
 #include "components/payments/payment_request_delegate.h"
 #include "components/payments/payment_request_web_contents_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
 
 namespace payments {
 
 PaymentRequest::PaymentRequest(
     content::WebContents* web_contents,
     std::unique_ptr<PaymentRequestDelegate> delegate,
     PaymentRequestWebContentsManager* manager,
     mojo::InterfaceRequest<payments::mojom::PaymentRequest> request)
     : web_contents_(web_contents),
       delegate_(std::move(delegate)),
       manager_(manager),
       binding_(this, std::move(request)),
       selected_shipping_profile_(nullptr),
       selected_contact_profile_(nullptr) {

[please use gerrit instead, 2017/02/14 00:29:14]

Need to initialize selected_credit_card_ to nullptr here. Otherwise the pointer
is initialized to point to a random location in memory.

[anthonyvd, 2017/02/22 20:15:21]

Done.

   // OnConnectionTerminated will be called when the Mojo pipe is closed. This
   // will happen as a result of many renderer-side events (both successful and
   // erroneous in nature).
   // TODO(crbug.com/683636): Investigate using
   // set_connection_error_with_reason_handler with Binding::CloseWithReason.
   binding_.set_connection_error_handler(base::Bind(
       &PaymentRequest::OnConnectionTerminated, base::Unretained(this)));
 
 }
 
@@ skipping 75 matching lines @@
 const std::vector<autofill::AutofillProfile*>&
     PaymentRequest::shipping_profiles() {
   return shipping_profiles_;
 }
 
 const std::vector<autofill::AutofillProfile*>&
     PaymentRequest::contact_profiles() {
   return contact_profiles_;
 }
 
-autofill::CreditCard* PaymentRequest::GetCurrentlySelectedCreditCard() {
-  // TODO(anthonyvd): Change this code to prioritize server cards and implement
-  // a way to modify this function's return value.
+const std::vector<autofill::CreditCard*> PaymentRequest::credit_cards() {
   autofill::PersonalDataManager* data_manager =
       delegate_->GetPersonalDataManager();
 
-  const std::vector<autofill::CreditCard*> cards =
-      data_manager->GetCreditCardsToSuggest();
-
-  auto first_complete_card = std::find_if(
-      cards.begin(),
-      cards.end(),
-      [] (autofill::CreditCard* card) {
-        return card->IsValid();
-  });
-
-  return first_complete_card == cards.end() ? nullptr : *first_complete_card;
+  return data_manager->GetCreditCardsToSuggest();

[please use gerrit instead, 2017/02/14 00:29:14]

These cards are owned by data_manager and can change at any moment due to sync.
Please create a cache of them similar to profile_cache_, such that you have full
control of lifetimes of these objects.

[anthonyvd, 2017/02/22 20:15:21]

Ahh, didn't know that! Done. I imagine we'll need to listen for data manager
updates and update the cache as well.

 }
 
 void PaymentRequest::PopulateProfileCache() {
   autofill::PersonalDataManager* data_manager =
       delegate_->GetPersonalDataManager();
   std::vector<autofill::AutofillProfile*> profiles =
       data_manager->GetProfilesToSuggest();
 
   // PaymentRequest may outlive the Profiles returned by the Data Manager.
   // Thus, we store copies, and return a vector of pointers to these copies
   // whenever Profiles are requested.
   for (size_t i = 0; i < profiles.size(); i++) {
     profile_cache_.push_back(
         base::MakeUnique<autofill::AutofillProfile>(*profiles[i]));
 
     // TODO(tmartino): Implement deduplication rules specific to shipping and
     // contact profiles.
     shipping_profiles_.push_back(profile_cache_[i].get());
     contact_profiles_.push_back(profile_cache_[i].get());
   }
 }
 
 void PaymentRequest::SetDefaultProfileSelections() {
   if (!shipping_profiles().empty())
     set_selected_shipping_profile(shipping_profiles()[0]);
 
   if (!contact_profiles().empty())
     set_selected_contact_profile(contact_profiles()[0]);
+
+  // TODO(anthonyvd): Change this code to prioritize server cards and implement
+  // a way to modify this function's return value.
+  const std::vector<autofill::CreditCard*> cards = credit_cards();
+  auto first_complete_card = std::find_if(
+      cards.begin(),
+      cards.end(),
+      [] (autofill::CreditCard* card) {
+        return card->IsValid();
+  });
+
+  selected_credit_card_ =
+      first_complete_card == cards.end() ?nullptr : *first_complete_card;

[please use gerrit instead, 2017/02/14 00:29:14]

need space after "?"

[anthonyvd, 2017/02/22 20:15:21]

Done.

 }
 
 }  // namespace payments