[Web Payments] Add a mechanism to build item lists in the PR dialog.

chrome/browser/ui/views/payments/payment_request_views_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/vector_icons/vector_icons.h"
 #include "chrome/browser/ui/views/payments/payment_request_sheet_controller.h"
+#include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
+#include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/geometry/point_f.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/views/border.h"
 #include "ui/views/bubble/bubble_frame_view.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/button/vector_icon_button.h"
+#include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/painter.h"
 #include "ui/views/view.h"
 
 namespace {
 
 // TODO(tmartino): Consider combining this with the Android equivalent in
 // PersonalDataManager.java
@@ skipping 145 matching lines @@
 }
 
 // Creates a views::Border object that can paint the gray horizontal ruler used
 // as a separator between items in the Payment Request dialog.
 std::unique_ptr<views::Border> CreatePaymentRequestRowBorder() {
   return views::CreateBorderPainter(
       base::MakeUnique<PaymentRequestRowBorderPainter>(),
       gfx::Insets());
 }
 
+std::unique_ptr<views::View> CreateCreditCardIconView(
+    autofill::CreditCard* card) {

[please use gerrit instead, 2017/02/14 00:29:14]

Since only card->type() is used, I'd prefer a tighter interface that takes only
the type. (I think "Code Complete" recommends this, too.)

std::unique_ptr<views::View> CreateCreditCardIconView(const std::string&
card_type) {

[anthonyvd, 2017/02/22 20:15:21]

Agreed. Turns out this was implemented while I was out.

+  std::unique_ptr<views::ImageView> card_icon_view =
+      base::MakeUnique<views::ImageView>();
+  card_icon_view->set_interactive(false);
+  card_icon_view->SetImage(
+    ResourceBundle::GetSharedInstance()
+        .GetImageNamed(autofill::data_util::GetPaymentRequestData(
+            card->type()).icon_resource_id)
+        .AsImageSkia());
+  card_icon_view->SetBorder(
+      views::CreateRoundedRectBorder(1, 3, SK_ColorLTGRAY));
+
+  constexpr gfx::Size kCardIconSize = gfx::Size(32, 20);
+  card_icon_view->SetImageSize(kCardIconSize);
+
+  return card_icon_view;
+}
+
 }  // namespace payments