components/guest_view/renderer/guest_view_container.h - Issue 2695633008: Re-check existence of GuestViewContainer before requesting attach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/renderer/guest_view_container.h

Issue 2695633008: Re-check existence of GuestViewContainer before requesting attach. (Closed)

Patch Set: Remove unnecessary check. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/renderer/guest_view_container.h

diff --git a/components/guest_view/renderer/guest_view_container.h b/components/guest_view/renderer/guest_view_container.h

index e8f53d82df4b1078eb67c7658ac126b786898025..7025d95908fafb89229689bc8b1fadae64034b72 100644

--- a/components/guest_view/renderer/guest_view_container.h

+++ b/components/guest_view/renderer/guest_view_container.h

@@ -66,6 +66,7 @@ class GuestViewContainer : public content::BrowserPluginDelegate {

// BrowserPluginGuestDelegate public implementation.

void SetElementInstanceID(int element_instance_id) final;

void DidResizeElement(const gfx::Size& new_size) override;

+ base::WeakPtr<BrowserPluginDelegate> GetWeakPtr() final;

protected:

~GuestViewContainer() override;

@@ -89,7 +90,6 @@ class GuestViewContainer : public content::BrowserPluginDelegate {

// BrowserPluginDelegate implementation.

void Ready() final;

void DidDestroyElement() final;

- base::WeakPtr<BrowserPluginDelegate> GetWeakPtr() final;

int element_instance_id_;

content::RenderFrame* render_frame_;

« no previous file with comments | « no previous file | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »