Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2695633004: Handle top-level getters and setters in parts. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 3 chunks +6 lines, -3 lines 1 comment Download
A pkg/front_end/test/fasta/top_level_accessors.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/top_level_accessors.dart.direct.expect View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/top_level_accessors.dart.outline.expect View 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/test/fasta/top_level_accessors_part.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 10 months ago (2017-02-14 14:47:21 UTC) #2
ahe
https://codereview.chromium.org/2695633004/diff/1/pkg/front_end/test/fasta/testing.json File pkg/front_end/test/fasta/testing.json (right): https://codereview.chromium.org/2695633004/diff/1/pkg/front_end/test/fasta/testing.json#newcode54 pkg/front_end/test/fasta/testing.json:54: "/test/fasta/top_level_accessors_part\\.dart$" I've filed a bug to track this: https://github.com/dart-lang/sdk/issues/28767
3 years, 10 months ago (2017-02-14 14:49:46 UTC) #3
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-14 15:41:30 UTC) #4
ahe
3 years, 10 months ago (2017-02-14 16:16:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b4b219b59a8ca8df9f86e9c0585165d2e74f149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698