Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2695633002: Annotate native methods. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
index 8b50f1e8e9aaed9ca88014146742a041b94f1f76..e01a465cb55dc48331dc24dd93e2d5ebb09c9831 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
@@ -8,6 +8,7 @@ import 'package:kernel/ast.dart' show
Arguments,
AsyncMarker,
Constructor,
+ ConstructorInvocation,
DartType,
DynamicType,
EmptyStatement,
@@ -23,6 +24,8 @@ import 'package:kernel/ast.dart' show
ProcedureKind,
RedirectingInitializer,
Statement,
+ StaticInvocation,
+ StringLiteral,
SuperInitializer,
TypeParameter,
VariableDeclaration,
@@ -37,11 +40,14 @@ import 'package:kernel/type_algebra.dart' show
import '../errors.dart' show
internalError;
+import '../loader.dart' show
+ Loader;
import '../util/relativize.dart' show
relativizeUri;
import 'kernel_builder.dart' show
+ Builder,
ClassBuilder,
ConstructorReferenceBuilder,
FormalParameterBuilder,
@@ -56,16 +62,18 @@ import 'kernel_builder.dart' show
abstract class KernelFunctionBuilder
extends ProcedureBuilder<KernelTypeBuilder> {
+ final String nativeMethodName;
+
FunctionNode function;
Statement actualBody;
- KernelFunctionBuilder(
- List<MetadataBuilder> metadata,
- int modifiers, KernelTypeBuilder returnType, String name,
+ KernelFunctionBuilder(List<MetadataBuilder> metadata, int modifiers,
+ KernelTypeBuilder returnType, String name,
List<TypeVariableBuilder> typeVariables,
List<FormalParameterBuilder> formals,
- KernelLibraryBuilder compilationUnit, int charOffset)
+ KernelLibraryBuilder compilationUnit, int charOffset,
+ this.nativeMethodName)
: super(metadata, modifiers, returnType, name, typeVariables, formals,
compilationUnit, charOffset);
@@ -82,6 +90,8 @@ abstract class KernelFunctionBuilder
Statement get body => actualBody ??= new EmptyStatement();
+ bool get isNative => nativeMethodName != null;
+
FunctionNode buildFunction() {
assert(function == null);
FunctionNode result = new FunctionNode(body, asyncMarker: asyncModifier);
@@ -142,6 +152,22 @@ abstract class KernelFunctionBuilder
}
Member build(Library library);
+
+ void becomeNative(Loader loader) {
+ target.isExternal = true;
+ Builder constructor = loader.getNativeAnnotation();
+ Arguments arguments =
+ new Arguments(<Expression>[new StringLiteral(nativeMethodName)]);
+ Expression annotation;
+ if (constructor.isConstructor) {
+ annotation = new ConstructorInvocation(constructor.target, arguments)
+ ..isConst = true;
+ } else {
+ annotation = new StaticInvocation(constructor.target, arguments)
+ ..isConst = true;
+ }
+ target.addAnnotation(annotation);
+ }
}
class KernelProcedureBuilder extends KernelFunctionBuilder {
@@ -157,11 +183,11 @@ class KernelProcedureBuilder extends KernelFunctionBuilder {
List<TypeVariableBuilder> typeVariables,
List<FormalParameterBuilder> formals, this.actualAsyncModifier,
ProcedureKind kind, KernelLibraryBuilder compilationUnit, int charOffset,
- [this.redirectionTarget])
+ [String nativeMethodName, this.redirectionTarget])
: procedure = new Procedure(null, kind, null,
fileUri: relativizeUri(compilationUnit?.fileUri)),
super(metadata, modifiers, returnType, name, typeVariables, formals,
- compilationUnit, charOffset);
+ compilationUnit, charOffset, nativeMethodName);
ProcedureKind get kind => procedure.kind;
@@ -215,9 +241,10 @@ class KernelConstructorBuilder extends KernelFunctionBuilder {
int modifiers, KernelTypeBuilder returnType, String name,
List<TypeVariableBuilder> typeVariables,
List<FormalParameterBuilder> formals,
- KernelLibraryBuilder compilationUnit, int charOffset)
+ KernelLibraryBuilder compilationUnit, int charOffset,
+ [String nativeMethodName])
: super(metadata, modifiers, returnType, name, typeVariables, formals,
- compilationUnit, charOffset);
+ compilationUnit, charOffset, nativeMethodName);
bool get isInstanceMember => false;
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698