Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issue 2695633002: Annotate native methods. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -45 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/member_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 3 chunks +4 lines, -26 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 6 chunks +29 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 8 chunks +35 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 7 chunks +17 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 2 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (4 generated)
ahe
Native methods are now handled by the outline builder. This means that we know if ...
3 years, 10 months ago (2017-02-13 10:35:18 UTC) #4
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-13 14:14:06 UTC) #5
ahe
3 years, 10 months ago (2017-02-13 15:33:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
40fbcac6ed9cd74d39fde63d97dd5bc0009acc4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698