Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/web/BUILD.gn

Issue 2695593011: Error pages: Break retain cycle NativeContent/StaticHTMLViewController (Closed)
Patch Set: split ErrorPageGenerator and fix unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/static_content/static_html_view_controller.h ('k') | ios/chrome/browser/web/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/BUILD.gn
diff --git a/ios/chrome/browser/web/BUILD.gn b/ios/chrome/browser/web/BUILD.gn
index 679f3321cbe2512e22cea9a79a07cc4d87e76ffa..7cd4b1a7533101c208bb48a11dbf7bdccee3fc78 100644
--- a/ios/chrome/browser/web/BUILD.gn
+++ b/ios/chrome/browser/web/BUILD.gn
@@ -157,6 +157,8 @@ source_set("web_internal") {
"chrome_web_client.mm",
"error_page_content.h",
"error_page_content.mm",
+ "error_page_generator.h",
+ "error_page_generator.mm",
"external_app_launcher.h",
"external_app_launcher.mm",
"passkit_dialog_provider.h",
@@ -221,7 +223,7 @@ source_set("unit_tests_internal") {
"auto_reload_controller_unittest.mm",
"blocked_popup_tab_helper_unittest.mm",
"chrome_web_client_unittest.mm",
- "error_page_content_unittest.mm",
+ "error_page_generator_unittest.mm",
"external_app_launcher_unittest.mm",
"find_in_page_js_unittest.mm",
"js_findinpage_manager_unittest.mm",
« no previous file with comments | « ios/chrome/browser/ui/static_content/static_html_view_controller.h ('k') | ios/chrome/browser/web/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698