Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/web/error_page_content.h

Issue 2695593011: Error pages: Break retain cycle NativeContent/StaticHTMLViewController (Closed)
Patch Set: feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/static_content/static_html_view_controller.h ('k') | ios/chrome/browser/web/error_page_content.mm » ('j') | ios/chrome/browser/web/error_page_content.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/error_page_content.h
diff --git a/ios/chrome/browser/web/error_page_content.h b/ios/chrome/browser/web/error_page_content.h
index 1717de54805c54f4088c6ddc500c3db06b1d33ac..b8d16dc3757635b2e0e08a640948217627a39289 100644
--- a/ios/chrome/browser/web/error_page_content.h
+++ b/ios/chrome/browser/web/error_page_content.h
@@ -7,7 +7,6 @@
#import <UIKit/UIKit.h>
-#include "base/mac/scoped_nsobject.h"
#import "ios/chrome/browser/ui/static_content/static_html_native_content.h"
#import "ios/chrome/browser/ui/static_content/static_html_view_controller.h"
@@ -15,10 +14,7 @@ namespace web {
class BrowserState;
}
-@interface ErrorPageContent : StaticHtmlNativeContent<HtmlGenerator> {
- // Stores the HTML generated from the NSError in the initializer.
- base::scoped_nsobject<NSString> html_;
-}
+@interface ErrorPageContent : StaticHtmlNativeContent
// Initialization. |loader| and |url| are passed up to StaticHtmlNativeContent;
// |loader| cannot be nil.
« no previous file with comments | « ios/chrome/browser/ui/static_content/static_html_view_controller.h ('k') | ios/chrome/browser/web/error_page_content.mm » ('j') | ios/chrome/browser/web/error_page_content.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698