ios/chrome/browser/web/error_page_content.h - Issue 2695593011: Error pages: Break retain cycle NativeContent/StaticHTMLViewController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/web/error_page_content.h

Issue 2695593011: Error pages: Break retain cycle NativeContent/StaticHTMLViewController (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/web/error_page_content.h

diff --git a/ios/chrome/browser/web/error_page_content.h b/ios/chrome/browser/web/error_page_content.h

index 1717de54805c54f4088c6ddc500c3db06b1d33ac..7a86a98e11bfda3db5db2513225a0033ef78f687 100644

--- a/ios/chrome/browser/web/error_page_content.h

+++ b/ios/chrome/browser/web/error_page_content.h

@@ -15,7 +15,7 @@ namespace web {

class BrowserState;

}

-@interface ErrorPageContent : StaticHtmlNativeContent<HtmlGenerator> {

+@interface ErrorPageContent : StaticHtmlNativeContent {

// Stores the HTML generated from the NSError in the initializer.

base::scoped_nsobject<NSString> html_;

stkhapugin 2017/02/17 13:12:44 I think you don't need this anymore. If so, please

Olivier 2017/02/17 13:58:39 Correct, thanks Done

}