Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: base/message_loop/message_loop_unittest.cc

Issue 2695593009: Use the location where FileDescriptorWatcher is created to track the libevent handlers (Closed)
Patch Set: fix mac. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_descriptor_watcher_posix.cc ('k') | base/message_loop/message_pump_io_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop_unittest.cc
diff --git a/base/message_loop/message_loop_unittest.cc b/base/message_loop/message_loop_unittest.cc
index 263442839f764f729b7633cbe02da171b4837ce0..14fe1ee391ccc5c3c87778c6ab6b83d83edefee6 100644
--- a/base/message_loop/message_loop_unittest.cc
+++ b/base/message_loop/message_loop_unittest.cc
@@ -739,7 +739,7 @@ TEST(MessageLoopTest, FileDescriptorWatcherOutlivesMessageLoop) {
int fd = pipefds[1];
{
// Arrange for controller to live longer than message loop.
- MessageLoopForIO::FileDescriptorWatcher controller;
+ MessageLoopForIO::FileDescriptorWatcher controller(FROM_HERE);
{
MessageLoopForIO message_loop;
@@ -766,7 +766,7 @@ TEST(MessageLoopTest, FileDescriptorWatcherDoubleStop) {
// Arrange for message loop to live longer than controller.
MessageLoopForIO message_loop;
{
- MessageLoopForIO::FileDescriptorWatcher controller;
+ MessageLoopForIO::FileDescriptorWatcher controller(FROM_HERE);
QuitDelegate delegate;
message_loop.WatchFileDescriptor(fd,
« no previous file with comments | « base/files/file_descriptor_watcher_posix.cc ('k') | base/message_loop/message_pump_io_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698