Initial stub version of Async Clipboard API

third_party/WebKit/Source/core/clipboard/ClipboardAsync.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ClipboardAsync_h
+#define ClipboardAsync_h
+
+#include "bindings/core/v8/ScriptPromise.h"
+#include "core/CoreExport.h"
+#include "core/dom/ContextLifecycleObserver.h"
+#include "public/platform/WebClipboard.h"
+
+namespace blink {
+
+class DataTransfer;
+class ScriptPromiseResolver;
+
+class CORE_EXPORT ClipboardAsync final

[dcheng, 2017/05/13 22:18:32]

My main question about this is stylistic: this seems like helpers for
implementing Clipboard -- any reason to expose this publicly? Or perhaps name
this like ClipboardPromise, and instead of having schedule* methods, change them
to createForRead(), createForReadText(), etc?

I think it's easy for a reader to get the wrong impression that there's one
ClipboardAsync object, and you can call it multiple times with scheduleFoo()
methods.

[garykac, 2017/05/17 23:51:14]

Re: The name. That's a good point that I hadn't considered. Renamed to
ClipboardPromise and changed the create*() methods.

+    : public GarbageCollectedFinalized<ClipboardAsync>,
+      public ContextLifecycleObserver {
+  USING_GARBAGE_COLLECTED_MIXIN(ClipboardAsync);
+  WTF_MAKE_NONCOPYABLE(ClipboardAsync);
+
+ public:
+  virtual ~ClipboardAsync(){};
+
+  static ClipboardAsync* create(ScriptState*);

[dcheng, 2017/05/13 22:18:32]

Nit: to follow the updated style guide, these shoulw all be UpperCased, since
they aren't being consumed by the IDL.

[garykac, 2017/05/17 23:51:14]

Done.

+
+  ScriptPromise scheduleRead();
+  ScriptPromise scheduleReadText();
+
+  ScriptPromise scheduleWrite(DataTransfer*);
+  ScriptPromise scheduleWriteText(const String&);
+
+  // ContextLifecycleObserver
+  void ContextDestroyed(ExecutionContext*) override;
+
+  DECLARE_VIRTUAL_TRACE();
+
+ private:
+  ClipboardAsync(ScriptState*);
+
+  WebTaskRunner* getTaskRunner();
+
+  void handleRead();
+  void handleReadText();
+
+  void handleWrite(DataTransfer*);
+  void handleWriteText(const String&);
+
+  Member<ScriptPromiseResolver> m_scriptPromiseResolver;
+
+  WebClipboard::Buffer m_buffer;

[dcheng, 2017/05/13 22:18:32]

Similarly, this should be buffer_

[garykac, 2017/05/17 23:51:14]

Done.

+};
+
+}  // namespace blink
+
+#endif  // ClipboardAsync_h